feat: add support for csharp namespace in protobuf schemas #560
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enhances the
ConfluentProtobufTypeNameResolver
to respect thecsharp_namespace
option specified in protobuf files when resolving type names from the Confluent Schema Registry. Previously, the resolver did not consider this option and only used the protobuf package to construct the resolved name. This change ensures better compatibility with C# namespaces and avoids potential conflicts in projects using custom namespaces.Fixes #229
How Has This Been Tested?
csharp_namespace
option.Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement