Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the port to work on the MacOS Monterey #12

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

engtom
Copy link
Contributor

@engtom engtom commented Feb 8, 2022

PR Details

Changes the port from 5000 to 5999, to correct a bug that was preventing the server to start on the macOS Monterey

Description

When we were trying to connect to the server, this error was being shown: The operation couldn’t be completed. (SwiftSocket.SocketError error 2.). On the macOS Monterey, the port 5000 is used by Control Center, to operate the Airplay Receiver, so this was preventing the Mockingbird server to connect. Changing it to 5999 fixed the problem.

Also, we had to change the mitmproxy folder, due to the change we had to do on the mitmdump_mb file. The code we have today checks if the mitmproxy folder is empty and then we copy the file to it. This was preventing the file to be updated. So, we have found a temporary solution to overcome that, that is to change to name of the folder to mitmproxy-v2.

Also, the Swifter lib was updated to the 1.5.0 version.

Motivation and Context

This change is required to fix the function problem on the macOS Monterey

How Has This Been Tested

After fixing the problem, I ran the app several times and tested the intended behavior. Everything worked just fine

Types of changes

  • Docs change / refactoring / dependency upgrade
  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • X[ ] My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • [ X] I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@erickjung erickjung merged commit 64309cb into Farfetch:master Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants