generate_html_report.sh: Support path without trailing slash #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Farigh
force-pushed
the
fixup-no-leading-slash-path
branch
2 times, most recently
from
d9c7d49
to
5a05c16
Compare
If the execution rights are not set properly, the run_tests.sh script did not fail, even though the test-suite was never executed. The execution rights are now checked before trying to run a test-suite. If the check fails, an error is reported.
Passing a path without an ending slash could result in incorrect index.html generation. If the provided path does not end with a slash, it's now added. --- Added the following related tests to the `generate_html_outputs` test-suite: - relative_path_report(relative_path) - relative_path_report(relative_path_no_leading_slash) - relative_path_report(current_dir_in_path) - relative_path_report(current_dir_in_path_no_leading_slash) - relative_path_report(current_dir_out_path) - relative_path_report(current_dir_out_path_no_leading_slash) This test-suite covers both relative paths and non-slash ending paths as parameter values. The special "." and ".." values are tested as well. --- This commit fixes #7
Farigh
force-pushed
the
fixup-no-leading-slash-path
branch
6 times, most recently
from
4d27ce7
to
4c262aa
Compare
GitHub-CI does not run the tests in an interactive shell. Thus colors are disabled. Setting the memcheck_cover_always_use_colors variable to true will now enable colors even within a non-interactive environnement. This variable has been set to true if the GITHUB_RUN_ID is defined and not empty for test scripts.
Farigh
force-pushed
the
fixup-no-leading-slash-path
branch
from
4c262aa
to
ea5b4ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing a path without an ending slash could result in incorrect
index.html generation.
If the provided path does not end with a slash, it's now added.
Added the following related tests to the
generate_html_outputstest-suite:
This test-suite covers both relative paths and non-slash ending paths as
parameter values.
The special "." and ".." values are tested as well.
This commit fixes #7