Fix create F3D material error in Blender 3.1 #84
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #83
Looks like consequences of Blender fixing one or more bugs in Blender 3.1 maybe, potentially introducing another one I'm not sure
See my debug branch Dragorn421@06179bf for understanding what's printed below
3.1 output
What's weird here is there are two input sockets to the output node,
""
and"UV"
. this is what causes the issue with fast64 in the first place, the""
one is used but isn't an actual output so doesn't appear in the node group outputsso the fix is using the created socket as returned by the new() call
2.93 output
this indeed has a single input socket to the outputs node, but new() returns a socket that doesn't actually get a link made for some reason, which makes the fix for 3.1-fast64 not backwards compatible. this looks like a bug too, which got fixed somewhere after 2.93 I guess
So I ended up hardcoding a version for the fix...
I tested in 2.93 (and it should work in any < 3.1 since the fast64 behavior should be unaltered for these versions) and 3.1.