Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ATtiny 0/1 series #1061

Closed
wants to merge 1 commit into from
Closed

Add ATtiny 0/1 series #1061

wants to merge 1 commit into from

Conversation

freemovers
Copy link

Added the Attiny 0/1 series to the AVR platform

Added the ATtiny 0/1 series with pin-out to the AVR platform
@kriegsman
Copy link
Member

I think we're ready to merge this PR once the (new) conflicts are resolved. We just made some changes to the directory structure, so I think it'll be easy for you to resolve the conflicts and get this ready for merging. Thank you for the help and the contribution!

@jasoncoon jasoncoon mentioned this pull request Jan 26, 2021
@jasoncoon
Copy link
Member

I couldn't figure out a better way, so I made a new PR from @freemovers fork to mine, fixed the merge conflicts, made the change suggested by @geekmomprojects, tested them on an ATtiny1604, and made a new PR: #1183

@ngyl88
Copy link
Contributor

ngyl88 commented Sep 5, 2021

@jasoncoon @freemovers @kriegsman , please note that I created PR #1292 to resolve the merge conflicts. Please help to review the changes or test if possible. I don't have any board with me. =)

@kriegsman , from code maintenance point of view, the codes for AVR platform has grown to support AVR mega and AVR tiny. Before it's too late, maybe it's time to create platform subfolders for the 2 subs. The branch: https://github.com/FastLED/FastLED/tree/avrmega/platforms seems to share this idea, however it might have too much conflicts to resolve. It also seems to have some ATmega/ATtiny supports which we recently worked on, unsure if it's has valuable changes that we haven't absorb. This kind of refactoring will sometimes create regressions, unsure if we really want to start the clean ups. If we do, probably we could start collaborate in a new branch?

@kriegsman
Copy link
Member

Thank you so much for these contributions. And I like the idea of splitting out the AVR into multiple separate platforms.

@ngyl88 did you actually mean #1291 ? Or a different PR to resolve the merge conflicts?

@ngyl88
Copy link
Contributor

ngyl88 commented Sep 23, 2021

Oh no. There was a typo. It's #1292 instead.

@zackees
Copy link
Member

zackees commented Sep 18, 2024

Now merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants