Change order of arguments to IOContext constructor (group config objects together) #1071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JooHyukKim I should have noticed it earlier, but I think new config objects should be grouped together, so I moved |
cowtowncoder
commented
Aug 1, 2023
| * @deprecated Since 2.16, use {@link #IOContext(StreamReadConstraints, StreamWriteConstraints, BufferRecycler, | ||
| * ContentReference, boolean, ErrorReportConfiguration)} instead. | ||
| */ | ||
| @Deprecated |
There was a problem hiding this comment.
Not removed, moved further down (without Javadoc comment).
cowtowncoder
commented
Aug 1, 2023
| br, contentRef, managedResource); | ||
| } | ||
|
|
||
| @Deprecated // In 2.16: remove ASAP |
There was a problem hiding this comment.
Moved from further up; only needed temporarily since it'd have been added in 2.16 so once factories/builders call proper main constructor, this can be safely removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.