Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative number issue (2.13 branch - tests only) #781

Merged
merged 3 commits into from
Jun 25, 2022

Conversation

pjfanning
Copy link
Member

Relates to #777 - these tests also fail in 2.13 branch but with a different issue.

com.fasterxml.jackson.core.JsonParseException: Unexpected character ('.' (code 46)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
 at [Source: (StringReader); line: 1, column: 4]

	at com.fasterxml.jackson.core.JsonParser._constructError(JsonParser.java:2391)
	at com.fasterxml.jackson.core.base.ParserMinimalBase._reportError(ParserMinimalBase.java:735)
	at com.fasterxml.jackson.core.base.ParserMinimalBase.reportUnexpectedNumberChar(ParserMinimalBase.java:557)
	at com.fasterxml.jackson.core.json.ReaderBasedJsonParser._handleInvalidNumberStart(ReaderBasedJsonParser.java:1718)
	at com.fasterxml.jackson.core.json.ReaderBasedJsonParser._parseNegNumber(ReaderBasedJsonParser.java:1467)
	at com.fasterxml.jackson.core.json.ReaderBasedJsonParser.nextToken(ReaderBasedJsonParser.java:784)
	at com.fasterxml.jackson.failing.FailingNonStandardNumberParsingTest._testLeadingDotInNegativeDecimalAllowed(FailingNonStandardNumberParsingTest.java:37)
	at com.fasterxml.jackson.failing.FailingNonStandardNumberParsingTest.testLeadingDotInNegativeDecimalAllowedReader(FailingNonStandardNumberParsingTest.java:30)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at junit.framework.TestCase.runTest(TestCase.java:177)
	at junit.framework.TestCase.runBare(TestCase.java:142)
	at junit.framework.TestResult$1.protect(TestResult.java:122)
	at junit.framework.TestResult.runProtected(TestResult.java:142)
	at junit.framework.TestResult.run(TestResult.java:125)
	at junit.framework.TestCase.run(TestCase.java:130)
	at junit.framework.TestSuite.runTest(TestSuite.java:241)
	at junit.framework.TestSuite.run(TestSuite.java:236)

@pjfanning pjfanning changed the title Negative number issue 2.13 Negative number issue (2.13 branch - tests only) Jun 24, 2022
@cowtowncoder
Copy link
Member

Sounds good. I am not sure if these are worth tackling for 2.13 but we can definitely add tests; will merge.

@cowtowncoder cowtowncoder merged commit 80d4776 into FasterXML:2.13 Jun 25, 2022
@pjfanning pjfanning deleted the negative-number-issue-2.13 branch June 25, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants