Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two cases of incorrect error reporting about DeserializationFeature #3038

Closed
wants to merge 1 commit into from

Conversation

jellevoost
Copy link

While using the DeserializationFeature.FAIL_ON_NULL_CREATOR_PROPERTIES setting I came across an error that did not match with the actual setting it was referring about. This led to an error referring to 'FAIL_ON_NULL_FOR_CREATOR_PARAMETERS' which I found to not exist on the DeserializationFeature.

I would assume this setting was renamed at some point in the past and the report was not adjusted accordingly, but I could be wrong about that of course.

In case I'm missing something for this PR just let me know.

cowtowncoder added a commit that referenced this pull request Feb 1, 2021
@cowtowncoder cowtowncoder modified the milestones: 1.9.13, 2.12.2 Feb 1, 2021
@cowtowncoder
Copy link
Member

@jellevoost Thank you! Since this is present in earlier versions too (master is for 3.0.0 development), I went ahead and manually merged fix in 2.12 (for 2.12.2) -- you are right, there was a discrepancy for some reason. Possibly cut'n paste issue or something, although could have been a very old rename from Jackson 1.x -> 2.x timeframe (cannot rename in a minor version).
Either way, good catch: that exception would have been confusing. :)

Thank you once again for contributing this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants