Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML TomlParserTest#float fails on master (3.0) #466

Closed
cowtowncoder opened this issue Feb 29, 2024 · 4 comments
Closed

TOML TomlParserTest#float fails on master (3.0) #466

cowtowncoder opened this issue Feb 29, 2024 · 4 comments
Labels
TOML Issue related to TOML format backend

Comments

@cowtowncoder
Copy link
Member

cowtowncoder commented Feb 29, 2024

Just noticed that one test is now failing on master -- probably not due to TOML format module but maybe something in core JSON parser?

Anyway, it's

    @Test
    public void floats() throws IOException {
    }

in TomlParserTest (I renamed this from ParserTest)

@cowtowncoder cowtowncoder added the TOML Issue related to TOML format backend label Feb 29, 2024
@cowtowncoder
Copy link
Member Author

@yawkat if you have a chance, would appreciate your help -- I am not sure which change in jackson-core might have caused this. One recent change to quoting of / by default (which caused a few test breaks) does not seem relevant, and I didn't think settings for fast-FP processing were changed for 3.0.

@cowtowncoder
Copy link
Member Author

On fast-fp, settings I see are:

src/main/java/tools/jackson/core/StreamReadFeature.java:    USE_FAST_DOUBLE_PARSER(false),
src/main/java/tools/jackson/core/StreamReadFeature.java:    USE_FAST_BIG_NUMBER_PARSER(false)
src/main/java/tools/jackson/core/StreamWriteFeature.java:    USE_FAST_DOUBLE_WRITER(false)

that is, still defaulting to disabled by default for now. Although probably will want to enable them for 3.0 at some point.

@cowtowncoder cowtowncoder changed the title TOML ParserTest#float fails on master (3.0) TOML TomlParserTest#float fails on master (3.0) Feb 29, 2024
@cowtowncoder
Copy link
Member Author

Ok, I think this: FasterXML/jackson-databind#3651 -- and in particular change of JsonNodeFeature.STRIP_TRAILING_BIGDECIMAL_ZEROES default to false in 3.0 is what is somehow causing this.

@cowtowncoder
Copy link
Member Author

Hmmh. Ok, decided to change configuration of ObjectMappers to make test pass.
Still not sure why normalization handling by TomlMapper differs. Oh well, something to look out for in future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TOML Issue related to TOML format backend
Projects
None yet
Development

No branches or pull requests

1 participant