Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upstream support + example #10

Closed
wants to merge 1 commit into from
Closed

Upstream support + example #10

wants to merge 1 commit into from

Conversation

aranc
Copy link

@aranc aranc commented Dec 13, 2020

@pep8speaks
Copy link

pep8speaks commented Dec 13, 2020

Hello @aranc! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 10:80: E501 line too long (89 > 79 characters)
Line 12:80: E501 line too long (90 > 79 characters)

Line 33:80: E501 line too long (88 > 79 characters)
Line 119:80: E501 line too long (82 > 79 characters)
Line 174:29: E231 missing whitespace after ':'
Line 174:61: E231 missing whitespace after ':'
Line 174:80: E501 line too long (99 > 79 characters)
Line 174:93: E231 missing whitespace after ':'
Line 199:80: E501 line too long (89 > 79 characters)

Line 25:22: E261 at least two spaces before inline comment
Line 25:23: E262 inline comment should start with '# '
Line 29:20: E231 missing whitespace after ':'
Line 30:33: E261 at least two spaces before inline comment
Line 44:24: E231 missing whitespace after ':'
Line 45:37: E261 at least two spaces before inline comment

Comment last updated at 2020-12-13 16:51:35 UTC

@aranc aranc closed this Dec 13, 2020
@aranc aranc reopened this Dec 13, 2020
@aranc
Copy link
Author

aranc commented Dec 13, 2020

An issue I encountered: you must send at least one message before firebase starts forwarding you upstream messages. This can be any message, including to invalid device_tokens. Other than that the upsteam seems to work (so far)

@aranc aranc closed this Dec 13, 2020
@aranc
Copy link
Author

aranc commented Dec 13, 2020

There are still similar loss of connection issues. I'll open a new pull request after I'll find the issue

@aranc
Copy link
Author

aranc commented Dec 14, 2020

(Moved to: #11)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants