refactor: remove unnecessary else blocks after throws (#1317)

Fdawgs · Mar 12, 2023 · e79699e · e79699e
1 parent 2b6897e
commit e79699e
Show file tree

Hide file tree

Showing 9 changed files with 14 additions and 24 deletions.
diff --git a/src/plugins/pdf-to-html/index.js b/src/plugins/pdf-to-html/index.js
@@ -132,12 +132,11 @@ async function plugin(server, options) {
 			 * Poppler will throw if the .pdf file provided
 			 * by client is malformed, thus client error code
 			 */
-			/* istanbul ignore else: unable to test unknown errors */
 			if (/Syntax Error:/.test(err)) {
 				throw server.httpErrors.badRequest();
-			} else {
-				throw err;
 			}
+			/* istanbul ignore next: unable to test unknown errors */
+			throw err;
 		}
 
 		/**

diff --git a/src/plugins/pdf-to-txt/index.js b/src/plugins/pdf-to-txt/index.js
@@ -153,12 +153,11 @@ async function plugin(server, options) {
 				 * Poppler will throw if the .pdf file provided
 				 * by client is malformed, thus client error code
 				 */
-				/* istanbul ignore else: unable to test unknown errors */
 				if (/Syntax Error:/.test(err)) {
 					throw server.httpErrors.badRequest();
-				} else {
-					throw err;
 				}
+				/* istanbul ignore next: unable to test unknown errors */
+				throw err;
 			}
 
 			// glob sorts files alphabetically
@@ -194,12 +193,11 @@ async function plugin(server, options) {
 				 * Poppler will throw if the .pdf file provided
 				 * by client is malformed, thus client error code
 				 */
-				/* istanbul ignore else: unable to test unknown errors */
 				if (/Syntax Error:/.test(err)) {
 					throw server.httpErrors.badRequest();
-				} else {
-					throw err;
 				}
+				/* istanbul ignore next: unable to test unknown errors */
+				throw err;
 			}
 		}
 

diff --git a/src/plugins/rtf-to-html/index.js b/src/plugins/rtf-to-html/index.js
@@ -156,12 +156,11 @@ async function plugin(server, options) {
 			 * UnRTF will throw if the .rtf file provided
 			 * by client is malformed, thus client error code
 			 */
-			/* istanbul ignore else: unable to test unknown errors */
 			if (/File is not the correct media type/.test(err)) {
 				throw server.httpErrors.badRequest();
-			} else {
-				throw err;
 			}
+			/* istanbul ignore next: unable to test unknown errors */
+			throw err;
 		}
 
 		res.type("text/html");

diff --git a/src/routes/docx/html/index.js b/src/routes/docx/html/index.js
@@ -41,9 +41,8 @@ async function route(server, options) {
 					"application/vnd.openxmlformats-officedocument.wordprocessingml.document"
 			) {
 				throw server.httpErrors.unsupportedMediaType();
-			} else {
-				return payload;
 			}
+			return payload;
 		}
 	);
 

diff --git a/src/routes/docx/txt/index.js b/src/routes/docx/txt/index.js
@@ -41,9 +41,8 @@ async function route(server, options) {
 					"application/vnd.openxmlformats-officedocument.wordprocessingml.document"
 			) {
 				throw server.httpErrors.unsupportedMediaType();
-			} else {
-				return payload;
 			}
+			return payload;
 		}
 	);
 

diff --git a/src/routes/pdf/html/index.js b/src/routes/pdf/html/index.js
@@ -41,9 +41,8 @@ async function route(server, options) {
 				results.mime !== "application/pdf"
 			) {
 				throw server.httpErrors.unsupportedMediaType();
-			} else {
-				return payload;
 			}
+			return payload;
 		}
 	);
 

diff --git a/src/routes/pdf/txt/index.js b/src/routes/pdf/txt/index.js
@@ -41,9 +41,8 @@ async function route(server, options) {
 				results.mime !== "application/pdf"
 			) {
 				throw server.httpErrors.unsupportedMediaType();
-			} else {
-				return payload;
 			}
+			return payload;
 		}
 	);
 

diff --git a/src/routes/rtf/html/index.js b/src/routes/rtf/html/index.js
@@ -41,9 +41,8 @@ async function route(server, options) {
 				results.mime !== "application/rtf"
 			) {
 				throw server.httpErrors.unsupportedMediaType();
-			} else {
-				return payload;
 			}
+			return payload;
 		}
 	);
 

diff --git a/src/routes/rtf/txt/index.js b/src/routes/rtf/txt/index.js
@@ -42,9 +42,8 @@ async function route(server, options) {
 				results.mime !== "application/rtf"
 			) {
 				throw server.httpErrors.unsupportedMediaType();
-			} else {
-				return payload;
 			}
+			return payload;
 		}
 	);