Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for adjustment of precision/sig digits #160

Open
HeatherKates opened this issue Jul 6, 2021 · 1 comment
Open

Allow for adjustment of precision/sig digits #160

HeatherKates opened this issue Jul 6, 2021 · 1 comment

Comments

@HeatherKates
Copy link

Hi! It would be great if there were an option for phyx programs to allow for user-specified prevision in output values (I'm thinking specifically of branch lengths). I have two issues that arise from the default - 1) The output trees are not always directly comparable with the input if it was generated from another program (this causes a problem when trying to search for subtrees, etc.), and 2) Very short branches are collapsed as polytomies. I know for that point the argument could be made that branches that short should be collapsed, but sometimes the bifurcation is needed for downstream analysis etc.

If there's already a way for a user to do this without altering the source code and I have missed it, please let me know.

Thank you!

@josephwb
Copy link
Member

josephwb commented Jul 6, 2021

The significance is hard-coded; I believe we matched the RAxML code. I am also not thrilled by it (for the same reasons you state). I have been thinking of a way to keep/process the edge lengths as strings.
I will figure this out, but it is not a simple fix, and will take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants