Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotorConstraint in FabrikJoint3D as xmlAttribute + ApplicationPerfTest unit test #10

Merged
merged 1 commit into from
Jun 6, 2017

Conversation

jmsjr
Copy link
Contributor

@jmsjr jmsjr commented Jun 4, 2017

Summary

  • Bugfix: Add rotorConstraint in FabrikJoint3D as xmlAttribute
  • Add JUnit asserts in ApplicationPerfTest, comparing pre-saved chains with the result of the unit test. A failure in the assert will indicate a change in the algorithm.

- Add asserts in ApplicationPerfTest
@alansley alansley merged commit 2b4b089 into FedUni:master Jun 6, 2017
@alansley
Copy link
Collaborator

alansley commented Jun 7, 2017

Some of those comparison files are kinda large, but I don't think it's worth streaming them to/from zip format. So yeah - good work, fella!

Just experimenting with modifying how constraints work due to #11 - so they might have to be regenerated if I can get it right. Have got an idea I'll work on for a bit shortly and see how I get on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants