Avoid index-out-of-range exception with back-to-back notes. #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also modified a test case.
dcdolson
commented
Apr 29, 2021
| @@ -211,8 +211,9 @@ def __alterDocstring(self, tail='', writer=None): | |||
| match = tagRE.search(line) | |||
| if match: | |||
| # We've got a simple one-line Doxygen command | |||
| lines[-1], inCodeBlock = self._endCodeIfNeeded( | |||
| lines[-1], inCodeBlock) | |||
| if lines: | |||
dcdolson
commented
Apr 29, 2021
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| This is basically as close a copy of the Python examples in the Google | |||
| Python Style Guide as possible while still being valid code. | |||
| NOTE: this is a note | |||
| NOTE: this is also a note | |||
There was a problem hiding this comment.
If you try these changes without the fix, this will crash doxpypy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also modified a test case.
This might fix some of the index-out-of-range issues some of your users are getting.