-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle findAndModify
and update
correctly when collection doesn't exist
#1087
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1087 +/- ##
==========================================
+ Coverage 65.57% 65.72% +0.15%
==========================================
Files 248 248
Lines 11816 11817 +1
==========================================
+ Hits 7748 7767 +19
+ Misses 3198 3182 -16
+ Partials 870 868 -2
Flags with carried forward coverage won't be shown. Click here to find out more. |
9f97c3c
to
fbb91ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As our idea was to understand how mongo behaves and offer the same behavior, this looks good enough to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR closes #651.
Readiness checklist
task all
, and it passed.task godocs
.@FerretDB/core
), Assignee, Labels, Project and project's Sprint fields.