Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helper for getting required parameters #339

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Mar 8, 2022

Refs #326.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Mar 8, 2022
@AlekSi AlekSi added this to the v0.0.7 milestone Mar 8, 2022
@AlekSi AlekSi added the trust PRs that can access Actions secrets label Mar 8, 2022
@AlekSi AlekSi enabled auto-merge (squash) March 8, 2022 13:02
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #339 (9c0025a) into main (537f050) will decrease coverage by 0.63%.
The diff coverage is 25.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #339      +/-   ##
==========================================
- Coverage   52.14%   51.51%   -0.64%     
==========================================
  Files         114      115       +1     
  Lines        5525     5591      +66     
==========================================
- Hits         2881     2880       -1     
- Misses       2232     2281      +49     
- Partials      412      430      +18     
Impacted Files Coverage Δ
internal/handlers/msg_listcollections.go 0.00% <0.00%> (ø)
internal/handlers/sql/msg_delete.go 0.00% <0.00%> (ø)
internal/handlers/sql/msg_insert.go 0.00% <0.00%> (ø)
internal/handlers/handler.go 53.52% <14.28%> (-3.02%) ⬇️
internal/handlers/msg_collstats.go 54.54% <16.66%> (-7.96%) ⬇️
internal/handlers/jsonb1/msg_find_or_count.go 72.00% <25.00%> (-1.47%) ⬇️
internal/handlers/msg_dbstats.go 69.23% <25.00%> (-5.77%) ⬇️
internal/handlers/jsonb1/msg_delete.go 56.92% <33.33%> (-5.15%) ⬇️
internal/handlers/jsonb1/msg_insert.go 54.34% <33.33%> (-7.20%) ⬇️
internal/handlers/jsonb1/msg_update.go 53.71% <33.33%> (-2.43%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 537f050...9c0025a. Read the comment docs.

@AlekSi AlekSi requested a review from w84thesun March 8, 2022 13:14
@AlekSi AlekSi merged commit e3f2cea into FerretDB:main Mar 8, 2022
@AlekSi AlekSi deleted the required-args branch March 8, 2022 13:17
w84thesun pushed a commit to w84thesun/FerretDB that referenced this pull request Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements trust PRs that can access Actions secrets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants