-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve contributing documentation for Windows development #795
Improve contributing documentation for Windows development #795
Conversation
Codecov Report
@@ Coverage Diff @@
## main #795 +/- ##
==========================================
- Coverage 59.51% 59.47% -0.04%
==========================================
Files 214 214
Lines 9447 9447
==========================================
- Hits 5622 5619 -3
- Misses 3174 3176 +2
- Partials 651 652 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would you please run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like I need to understand Windows problems better. Let's do a call later today
be55a6f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Had a call with Dmitry to discuss how WSL 2 works. It is pretty cool, but connectivity between WSL VMs (that share the same kernel!) is quite complicated. Rewrote text to shift accent to the fact that "WSL 2 distros" are not supported. |
Description
This PR refs #388.
Add more documentation for Windows contributors. Show how to run commands, what works and what's not.