Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak tests #837

Merged
merged 1 commit into from
Jul 4, 2022
Merged

Tweak tests #837

merged 1 commit into from
Jul 4, 2022

Conversation

AlekSi
Copy link
Member

@AlekSi AlekSi commented Jul 4, 2022

Description

This PR closes #836.

Readiness checklist

  • I added tests for new functionality or bugfixes.
  • I ran task all, and it passed.

@AlekSi AlekSi added the code/chore Code maintenance improvements label Jul 4, 2022
@AlekSi AlekSi added this to the v0.5.0 milestone Jul 4, 2022
@AlekSi AlekSi requested a review from rumyantseva as a code owner July 4, 2022 14:41
@AlekSi AlekSi self-assigned this Jul 4, 2022
@AlekSi AlekSi enabled auto-merge (squash) July 4, 2022 14:42
@AlekSi AlekSi requested review from ribaraka and noisersup July 4, 2022 14:42
Copy link
Contributor

@rumyantseva rumyantseva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, that doesn't look stable (but I don't have a better idea).

@codecov
Copy link

codecov bot commented Jul 4, 2022

Codecov Report

Merging #837 (19b55e5) into main (0af6150) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #837      +/-   ##
==========================================
- Coverage   59.11%   59.08%   -0.04%     
==========================================
  Files         217      217              
  Lines        9817     9817              
==========================================
- Hits         5803     5800       -3     
- Misses       3304     3306       +2     
- Partials      710      711       +1     
Impacted Files Coverage Δ
internal/util/version/version.go 55.00% <0.00%> (-5.00%) ⬇️
Flag Coverage Δ
FerretDB 61.29% <ø> (-0.04%) ⬇️
MongoDB 7.23% <ø> (-0.04%) ⬇️
integration 61.39% <ø> (-0.04%) ⬇️
unit 27.64% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@AlekSi
Copy link
Member Author

AlekSi commented Jul 4, 2022

You and me both :)

@AlekSi AlekSi disabled auto-merge July 4, 2022 14:57
@AlekSi AlekSi enabled auto-merge (squash) July 4, 2022 14:57
@AlekSi AlekSi disabled auto-merge July 4, 2022 15:00
@AlekSi AlekSi merged commit f799608 into FerretDB:main Jul 4, 2022
@AlekSi AlekSi deleted the tweak-diffs branch July 4, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix test error when issuing task all
5 participants