Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to local condensation of constraints #571

Merged
merged 3 commits into from
Dec 21, 2022

Conversation

fredrikekre
Copy link
Member

Some changes extracted from #567, see commits and commit messages.

Perhaps addindex! should just be methods of assemble!, they do the same thing, really (with argument order reversed since addindex! matches Base.setindex!).

@codecov-commenter
Copy link

Codecov Report

Base: 92.88% // Head: 0.00% // Decreases project coverage by -92.88% ⚠️

Coverage data is based on head (e65224f) compared to base (4de2b6c).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #571       +/-   ##
==========================================
- Coverage   92.88%   0.00%   -92.89%     
==========================================
  Files          25      25               
  Lines        4064    4016       -48     
==========================================
- Hits         3775       0     -3775     
- Misses        289    4016     +3727     
Impacted Files Coverage Δ
src/Dofs/ConstraintHandler.jl 0.00% <0.00%> (-95.93%) ⬇️
src/arrayutils.jl 0.00% <0.00%> (-65.63%) ⬇️
src/assembler.jl 0.00% <0.00%> (-99.33%) ⬇️
src/L2_projection.jl 0.00% <0.00%> (-100.00%) ⬇️
src/FEValues/cell_values.jl 0.00% <0.00%> (-100.00%) ⬇️
src/FEValues/face_values.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Grid/grid_generators.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Dofs/apply_analytical.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Quadrature/gaussquad_tet_table.jl 0.00% <0.00%> (-100.00%) ⬇️
src/Quadrature/gaussquad_tri_table.jl 0.00% <0.00%> (-100.00%) ⬇️
... and 18 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fredrikekre fredrikekre merged commit fac88b3 into master Dec 21, 2022
@fredrikekre fredrikekre deleted the fe/matrix-vector-handle branch December 21, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants