Use BitSet in apply_analytical! and reshape_to_nodes
#660
Conversation
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #660 +/- ##
==========================================
- Coverage 92.99% 92.97% -0.02%
==========================================
Files 30 30
Lines 4497 4500 +3
==========================================
+ Hits 4182 4184 +2
- Misses 315 316 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
I don't know how it affects performance in a mixed case with sparse cellsets though, but I also don't think this function is very performance critical so more important to not decrease single-fieldhandler performance.
Found one extra performance boost option for single field...
This patch uses `BitSet` in `apply_analytical!` and `reshape_to_nodes` for `MixedDofHandler`. The benefit here is twofold: computing the intersection is much faster (basically just bitwise `&`) and the subsequent looping over the cells are done in ascending cell order. This closes the performance gap between `MixedDofHandler` and `DofHandler` in benchmarks from #629 of `apply_analytical!`, `reshape_to_nodes`, and `vtk_point_data`. For example, here is the benchmark results for `apply_analytical!`: ``` 387.853 ms (72 allocations: 34.50 MiB) # MixedDofHandler master 55.262 ms (38 allocations: 553.45 KiB) # MixedDofHandler patch 41.861 ms (14 allocations: 2.27 KiB) # DofHandler master/patch ```
fredrikekre
force-pushed
the
fe/apply_analytical
branch
from
213539a
to
56e826d
Compare
This patch uses
BitSetinapply_analytical!andreshape_to_nodesforMixedDofHandler. The benefit here is twofold: computing the intersection is much faster (basically just bitwise&) and the subsequent looping over the cells are done in ascending cell order.This closes the performance gap between
MixedDofHandlerandDofHandlerin benchmarks from #629 ofapply_analytical!,reshape_to_nodes, andvtk_point_data. For example, here is the benchmark results forapply_analytical!: