Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document all the reference shapes and their (current) numbering #688

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

fredrikekre
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4106fb8) 92.90% compared to head (f896517) 92.90%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #688   +/-   ##
=======================================
  Coverage   92.90%   92.90%           
=======================================
  Files          30       30           
  Lines        4324     4324           
=======================================
  Hits         4017     4017           
  Misses        307      307           
Impacted Files Coverage Δ
src/Ferrite.jl 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@termi-official termi-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also leave a hint for https://ferrite-fem.github.io/FerriteViz.jl/dev/api/#FerriteViz.elementinfo which displays element information interactively.

src/docs.jl Outdated Show resolved Hide resolved
src/docs.jl Outdated Show resolved Hide resolved
src/docs.jl Outdated Show resolved Hide resolved
@fredrikekre
Copy link
Member Author

We could also leave a hint for https://ferrite-fem.github.io/FerriteViz.jl/dev/api/#FerriteViz.elementinfo which displays element information interactively.

Done! :)

Copy link
Member

@termi-official termi-official left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great and thanks! I went over them once more and I think they reflect these docs current implementation.

@fredrikekre
Copy link
Member Author

Thanks for the review!

@fredrikekre fredrikekre merged commit f923711 into master Apr 28, 2023
@fredrikekre fredrikekre deleted the fe/devdocs-reference-cells branch April 28, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants