Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve boundschecks during assemble #706

Merged
merged 2 commits into from
May 11, 2023
Merged

Conversation

KnutAM
Copy link
Member

@KnutAM KnutAM commented May 11, 2023

I think this should be safer, but I haven't benchmarked if there is a performance regression.

@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (c6c185c) 92.61% compared to head (2d0effb) 92.61%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #706   +/-   ##
=======================================
  Coverage   92.61%   92.61%           
=======================================
  Files          30       30           
  Lines        4430     4430           
=======================================
  Hits         4103     4103           
  Misses        327      327           
Impacted Files Coverage Δ
src/assembler.jl 99.34% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@fredrikekre fredrikekre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose requiring the same length is enough if we instead do

for (i, j) in zip(keys(ge), keys(dofs))
    addindex!(g, ge[i], dofs[j])
end

but in practice you would never utilize this extra degree of freedom I don't think.

@KnutAM KnutAM merged commit 799a9ee into master May 11, 2023
@KnutAM KnutAM deleted the kam/assembleinboundschecks branch May 11, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants