-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
InterfaceValues
for DG interface integration
#743
InterfaceValues
for DG interface integration
#743
Conversation
…AlazezAhmed/Ferrite.jl into face-integration-experiments
…AlazezAhmed/Ferrite.jl into face-integration-experiments
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #743 +/- ##
==========================================
+ Coverage 92.98% 93.08% +0.09%
==========================================
Files 33 34 +1
Lines 4950 5161 +211
==========================================
+ Hits 4603 4804 +201
- Misses 347 357 +10 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments. I think resolving these and the open ones and the PR should be good. We might want to leave mixed grids as future work.
I guess it is only left to merge master and resolving #743 (comment) |
I was able to use a lot of stuff in the PR for implementing "GhostPenalty" with my IGA elements, so thats really nice :) Only thing I noticed was that I had an really old verision of Tensors that did not include the functions rotation_tensor(::Float64, Float64, Float64). I did not get any error/warning from the package manager either. Does this mean that we should require Tensors to be >= v1.14.0 in the project file? |
There were a custom rotation tensor function in this PR previously but I removed it in favor of not repeating stuff since we already have it in Tensors.jl |
Good catch @lijas . Can you bump the compat here and merge master @AbdAlazezAhmed ? @fredrikekre do you have time for a final review from your side? I am happy with the state for now.:) |
…into face-integration-experiments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Great job :) Perhaps you can add an entry in the CHANGELOG? |
Tasks:
InterfaceValues
After merge
InterfaceValues