Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add threshold = "cut" back #110

Merged
merged 2 commits into from
Jun 10, 2024
Merged

add threshold = "cut" back #110

merged 2 commits into from
Jun 10, 2024

Conversation

dimalvovs
Copy link
Contributor

  • add threshold="cut" back
  • make best inclusion rank < and not <= first rank where intra-pattern becomes worse than inter-pattern;
  • create tests
  • update documentation

@dimalvovs dimalvovs linked an issue Jun 10, 2024 that may be closed by this pull request
Copy link
Collaborator

@jmitchell81 jmitchell81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The improvement of roxygen2 documentation for the patternMarkers function is greatly appreciated. The approach to thresholding based on the inter-pattern ranking of the feature is implemented clearly and efficiently. Unit tests are effective at ensuring that capability to detect pattern markers and disregard non-specific features. LGTM

@dimalvovs dimalvovs merged commit 5610b81 into master Jun 10, 2024
3 checks passed
@dimalvovs dimalvovs deleted the 109-fix-threshold=cut-mode branch June 10, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix threshold="cut" mode
2 participants