Use dict:dict() instead of dict()

[mururu]

No description provided.

[ethercrow]

+1

[ethercrow]

Typo: ditc instead of dict

[mururu]

Oh, Thanks :)

[voluntas]

+1

[thecodeboss]

+1
This allows for compiling under Erlang OTP 18, where simply using dict() was deprecated.

[scohen]

+1 We'd really like to use exometer in Erlang 18, and this is preventing us from doing so.

[tonyrog]

I guess type term() is better since older version of Erlang will generate an error:
"referring to built-in type dict as a remote type; please take out the module name"
Sometime I have resolved this with a -define(DICT_T(), term()) and then used ?DICT_T() as type. Very ugly, but works on more than one version of OTP. Yes I do use older versions, still use R15. R15 is installed by default on many systems.

[tonyrog]

Me and ulf determined that term() type was the best choice right now. We will probably fix this when most of our platforms support dict:dict().

[scohen]

I guess type term() is better since older version of Erlang will generate an error:
"referring to built-in type dict as a remote type; please take out the module name"

But netlink will not compile at all under 18.0.
In this case where you have a real incompatibility, ugly seems better than simply not working. The solution you presented seems to be something that could work under both circumstances. I urge you to reconsider.

[tonyrog]

Did the fix work or not?
I can not really parse what you are saying.

[scohen]

I'm sorry, I thought you weren't going to fix this since you closed the PR.

I'll give it a shot and report back.