Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static attribute can’t be final #401

Closed
Luro02 opened this issue Jan 31, 2024 · 0 comments · Fixed by #427
Closed

Static attribute can’t be final #401

Luro02 opened this issue Jan 31, 2024 · 0 comments · Fixed by #427
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.
Milestone

Comments

@Luro02
Copy link
Collaborator

Luro02 commented Jan 31, 2024

Summary

Given the code below, the static attribute i is readable and written to multiple times, so the attribute cannot be final.

Lint Name

FIELD_SHOULD_BE_FINAL

Reproducer

class A {
  private static int i; //# ok
  final int id;

  A() {
    i++;
    this.id = i;
  }
}
@Luro02 Luro02 added bug Something isn't working false-positive A lint triggers on something that is correct. labels Jan 31, 2024
@Luro02 Luro02 added this to the v0.6 milestone Jan 31, 2024
Luro02 added a commit to Luro02/autograder that referenced this issue Feb 8, 2024
@Luro02 Luro02 modified the milestones: v0.6.0, v0.5.30 Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant