Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve avoid shadowing lint, by only triggering when the shadowed variables are both used. #525

Closed
Luro02 opened this issue May 13, 2024 · 0 comments · Fixed by #597
Closed

Improve avoid shadowing lint, by only triggering when the shadowed variables are both used. #525

Luro02 opened this issue May 13, 2024 · 0 comments · Fixed by #597
Labels
bug Something isn't working false-positive A lint triggers on something that is correct. high-priority Issues that should be solved as soon as possible
Milestone
v0.7.0

Comments

@Luro02
Copy link
Collaborator

Luro02 commented May 13, 2024 •
edited
Loading

Summary

The lint should only trigger when both the shadowed variable and the variable that shadows it are used in the same method.

Alternative: Check how fields are referenced in other methods. If they are referenced by this. everywhere, then it is not that confusing to introduce a parameter/variable with the same name. Otherwise it could be confused.

Lint Name

AVOID_SHADOWING

Reproducer

<code>
@Luro02 Luro02 added bug Something isn't working false-positive A lint triggers on something that is correct. labels May 13, 2024
@Luro02 Luro02 added the high-priority Issues that should be solved as soon as possible label Jul 8, 2024
@Luro02 Luro02 modified the milestones: v0.6.0, v0.7.0 Sep 18, 2024
@Luro02 Luro02 mentioned this issue Sep 21, 2024
Merged
Luro02 added a commit to Luro02/autograder that referenced this issue Sep 24, 2024
@Luro02
reduce avoid shadowing annotations Feuermagier#525
e3d1e7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working false-positive A lint triggers on something that is correct. high-priority Issues that should be solved as soon as possible
Projects
None yet
Milestone
v0.7.0
Development

Successfully merging a pull request may close this issue.

Implement some things Luro02/autograder
1 participant
@Luro02