Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve avoid shadowing lint, by only triggering when the shadowed variables are both used. #525

Open
Luro02 opened this issue May 13, 2024 · 0 comments
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.

Comments

@Luro02
Copy link
Collaborator

Luro02 commented May 13, 2024

Summary

The lint should only trigger when both the shadowed variable and the variable that shadows it are used in the same method.

Alternative: Check how fields are referenced in other methods. If they are referenced by this. everywhere, then it is not that confusing to introduce a parameter/variable with the same name. Otherwise it could be confused.

Lint Name

AVOID_SHADOWING

Reproducer

<code>
@Luro02 Luro02 added bug Something isn't working false-positive A lint triggers on something that is correct. labels May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working false-positive A lint triggers on something that is correct.
Projects
None yet
Development

No branches or pull requests

1 participant