Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ignoreTest in documentation tests #200

Closed
novoj opened this issue Jul 26, 2023 · 1 comment · Fixed by #372
Closed

Remove ignoreTest in documentation tests #200

novoj opened this issue Jul 26, 2023 · 1 comment · Fixed by #372
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@novoj
Copy link
Collaborator

novoj commented Jul 26, 2023

Currently there are a few documentation tests that are disabled by the ignoreTest keyword because the GraphQL / REST requires special treatment - such as domain / url specification and environment preparation that is currently not happening properly.

This issue should investigate and fix all related issues so that the ignoreTest can be eliminated.

@novoj novoj added the documentation Improvements or additions to documentation label Jul 26, 2023
@novoj
Copy link
Collaborator Author

novoj commented Dec 8, 2023

I removed the ignoredTests flag and tried to get the tests to run. Now the GraphQL / REST / C-Sharp executables are setup/teardown by java require snippets (and a few other fixes were made), but it still doesn't run. Try io.evitadb.documentation.UserDocumentationTest#testSingleFileDocumentation tests - all java examples are ok, but the graphql/rest fail - I think it's got two roots:

  • Sometimes we need to call the endpoint /system and sometimes /evita (catalog name).
  • the examples are outdated and cannot be executed correctly

I need to confirm my hypothesis, and if it's the case, I'll continue with code fixes on Monday. But I cannot estimate how much the examples are correct or not (mutations).

lukashornych added a commit that referenced this issue Dec 12, 2023
lukashornych added a commit that referenced this issue Dec 12, 2023
lukashornych added a commit that referenced this issue Dec 13, 2023
lukashornych added a commit that referenced this issue Dec 13, 2023
lukashornych added a commit that referenced this issue Dec 13, 2023
…s" when using Java HttpClient instead of HttpUrlConnection to NOT reuse connections
lukashornych added a commit that referenced this issue Dec 13, 2023
@novoj novoj linked a pull request Dec 13, 2023 that will close this issue
novoj added a commit that referenced this issue Dec 13, 2023
…entation-tests

#200 remove ignoretest in documentation tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants