Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate web server from Undertow to Armeria #397

Closed
Khertys opened this issue Jan 3, 2024 · 5 comments
Closed

Migrate web server from Undertow to Armeria #397

Khertys opened this issue Jan 3, 2024 · 5 comments
Assignees
@Khertys
Labels
breaking change Backward incompatible data model change enhancement New feature or request
Milestone
Beta

Comments

@Khertys
Copy link
Collaborator

Khertys commented Jan 3, 2024 •
edited
Loading

Try to benchmark https://armeria.dev/ gRPC library and run performance tests against it. With none or a little performance toll, we should try to integrate it into evitaDB and replace the currently used one. This Armeria gRPC library could offer us many nice-to-have features (such as OpenAPI like documentation endpoint with playground for testing calls, implicit support for grpc-web standard,...) and much easier manipulation with gRPC-related structures.

In future, while migrating, also consider using AdvancedTlsX509KeyManager class from gRPC to enable certificate reloading capabilities (ie. for LetsEncrypt renew process).
@Khertys Khertys self-assigned this Jan 3, 2024
@novoj novoj changed the title Try alternate gRPC library Try alternative gRPC library Jan 4, 2024
@novoj novoj added the enhancement New feature or request label Jan 4, 2024
@novoj novoj added this to the Alpha milestone Jan 4, 2024
Khertys pushed a commit that referenced this issue Feb 22, 2024
feat(#397): introduced armeria gRPC library with modules problem
968dc4b
Khertys pushed a commit that referenced this issue Mar 22, 2024
fix(#397): attempt to adapt armeria grpc library with added java modu…
570e46b 
…les support
@novoj novoj modified the milestones: Alpha, Beta Apr 26, 2024
@trustin
Copy link

trustin commented May 16, 2024

As far as I understand, the JPMS-related blocker has been resolved in the recent Armeria versions. Would there be anything Armeria team could help with? We'd be happy to address any remaining issues for adoption.

@novoj
Copy link
Collaborator

novoj commented May 16, 2024

Hi @trustin - we're really positively surprised by your attitude and thank you very much for the support. The problem is currently on our side - we had to lower the priority for this issue due to other commercially important things. But we're planning to resume work on it by the end of May. The Armeria server could help us unify and simplify our internal infrastructure, so we see it as a way forward. We also want to update our performance tests and see what the impact of moving to the new solution will be and let you know the results.

Khertys pushed a commit that referenced this issue May 22, 2024
fix(#397): upgraded armeria library to latest version, exposed gRPC s…
9dd779f 
…erver on the same secured and non-secured port
@Khertys Khertys mentioned this issue May 22, 2024
Open
Khertys pushed a commit that referenced this issue Jun 21, 2024
feat(#397): migration to armeria web server
b5923a7
Khertys pushed a commit that referenced this issue Jun 24, 2024
feat(#397): correction of service routing, open api schema serializat…
4798c8a 
…ion and serving it from rest api, enabled gRPC server reflection
Khertys pushed a commit that referenced this issue Jun 24, 2024
feat(#397): refactored selected parts of processing api requests to b…
2ea3934 
…e handled in async manner via CompletableFutures to achieve a way to not accidentally use a thread used by the corresponding service
Khertys pushed a commit that referenced this issue Jun 24, 2024
feat(#397): added exposing the APIs on the machine hostname, added gR…
4b48746 
…PC documentation service
@novoj novoj added the breaking change Backward incompatible data model change label Jun 27, 2024
@novoj novoj changed the title Try alternative gRPC library Migrate web server from Undertow to Armeria Jun 27, 2024
Khertys pushed a commit that referenced this issue Jun 28, 2024
fix(#397): fixed exposing evitaLab files, enforce downloading certifi…
a35afe4 
…cate files instead of just visualising their content, added TlsMode to evita configuration, added decorator to router services to each API that ensures that API is used with the correct TLS mode
Khertys pushed a commit that referenced this issue Jul 2, 2024
fix(#397): fixed problems found while running functional test suite, …
d19af25 
…replaced gRPC client in Java driver with Armeria gRPC client, fixed routing and propagating query and path parameters via headers, test adaptation to changes, purged project of Undertow library
Khertys pushed a commit that referenced this issue Jul 2, 2024
fix(#397): renamed AbstractHttpService to EndpointService, added call…
8fad9c4 
…ing close method on EndpointRequest to ensure session closing
Khertys pushed a commit that referenced this issue Jul 3, 2024
fix(#397): fixed problems after dev merge
104380f
Khertys pushed a commit that referenced this issue Jul 3, 2024
fix(#397): fixed problems after dev merge
3db2f95
Khertys pushed a commit that referenced this issue Jul 3, 2024
fix(#397): added condition for enabling access log in armeria server,…
973efe1 
… patched readiness check in gRPC (temporarily)
novoj added a commit that referenced this issue Jul 11, 2024
@novoj
feat(#397): merged dev branch and fixed tests and compilation issues
a8a22f9
novoj added a commit that referenced this issue Jul 12, 2024
@novoj
feat(#397): revision and cleaning of Armeria setup
835c25c
novoj added a commit that referenced this issue Jul 13, 2024
@novoj
feat(#397): corrected copyrights to Undertow
9f7359e
novoj added a commit that referenced this issue Jul 13, 2024
@novoj
feat(#397): corrected copyrights to Undertow
11c569c
novoj added a commit that referenced this issue Jul 13, 2024
@novoj
feat(#397): corrected copyrights to Undertow
e94aea9
novoj added a commit that referenced this issue Jul 13, 2024
@novoj
feat(#397): revision and cleaning
d20dace
novoj added a commit that referenced this issue Jul 14, 2024
@novoj
feat(#397): fixed TLS scheme checking
7087fa3
Khertys pushed a commit that referenced this issue Jul 14, 2024
fix(#397): added test validating that it§s possible to communicate vi…
60b48ec 
…a gRPC-web standard
Khertys pushed a commit that referenced this issue Jul 15, 2024
fix(#397): allowed all request headers in gRPC to ensure proper gRPC-…
3537e57 
…Web functionality
lukashornych added a commit that referenced this issue Jul 15, 2024
@lukashornych
fix(#397): temporary fix to CORS from different origin
16d7fbb
novoj added a commit that referenced this issue Jul 15, 2024
@novoj
feat(#397): integrated and tested Armeria access log
9384235
@lukashornych lukashornych mentioned this issue Jul 16, 2024
Closed
lukashornych added a commit that referenced this issue Jul 16, 2024
@lukashornych
fix(#397): fix CORS implementation
f6a2689 
Our dynamic routes registering required dynamic CORS filters building and registering which the core Armeria CorsService cannot do. Therefore I used the original implementation from Undertow server.
novoj added a commit that referenced this issue Jul 16, 2024
@novoj
feat(#397): ports should be released only after Armeria actually stops
282c1e6
novoj added a commit that referenced this issue Jul 17, 2024
@novoj
feat(#397): management methods isolated in separate EvitaManagementSe…
1e0206c 
…rvice
novoj added a commit that referenced this issue Jul 17, 2024
@novoj
feat(#397): added catalog statistics service
b3ea075
novoj added a commit that referenced this issue Jul 17, 2024
@novoj
feat(#397): added naming variants on demand to schema services
01e3726
novoj added a commit that referenced this issue Jul 17, 2024
@novoj
feat(#397): finalized Armeria port handling
2f0ea82
novoj added a commit that referenced this issue Jul 17, 2024
@novoj
feat(#397): support for input / output decoding / encoding
7f6305a
novoj added a commit that referenced this issue Jul 17, 2024
@novoj
feat(#397): support for unsafe queries
2877f8c
novoj added a commit that referenced this issue Jul 17, 2024
@novoj
feat(#397): support for providing actual server side configuration vi…
7d1b165 
…a management service
novoj added a commit that referenced this issue Jul 18, 2024
@novoj
feat(#397): commented out problematic code from Armeria
57d76ac
novoj added a commit that referenced this issue Jul 22, 2024
@novoj
feat(#397): corrected HTTP header handling
7b4c97d 
... so that it works with Armeria compression decorator.
novoj added a commit that referenced this issue Jul 22, 2024
@novoj
feat(#397): writing directly bytes into the output
7ad4d65
@novoj
Copy link
Collaborator

novoj commented Jul 23, 2024

Only single step remaining - remeasuring in performance tests.

novoj added a commit that referenced this issue Jul 24, 2024
@novoj
feat(#397): added catalogId to CatalogStatistics
827d6e1
novoj added a commit that referenced this issue Jul 24, 2024
@novoj
feat(#397): session can be identified only by its UUID now
990272f 
We came to the conclusion that passing catalogName along with sessionId is redundant and requires additional overhead on the client side. So we decided to remove this requirement even if it costs more memory on the server side.
novoj added a commit that referenced this issue Jul 30, 2024
@novoj
feat(#397): Armeria server upgrade
f4c1679
novoj added a commit that referenced this issue Jul 31, 2024
@novoj
feat(#397): mutation history client implementation and tests
0470913
novoj added a commit that referenced this issue Aug 1, 2024
@novoj
feat(#397): corrected exception handling in separate executor
012ac5d
novoj added a commit that referenced this issue Aug 5, 2024
@novoj
feat(#397): removed service group configuration
40c455d 
It was found out that it only adds latency due to context switches and is not necessary after all.
novoj added a commit that referenced this issue Aug 5, 2024
@novoj
Merge pull request #640 from FgForrest/397-grpc-armeria-library-adapt…
76e014f 
…ation

feat(#397): switch to Armeria web server
@novoj
Copy link
Collaborator

novoj commented Aug 5, 2024 •
edited
Loading

Migration to Armeria server merged to dev branch (canary). It will be base for 2024.10

@novoj novoj closed this as completed Aug 5, 2024
@trustin
Copy link

trustin commented Aug 5, 2024

Lovely! Looking forward to more feedback from you and your teammates 🙇

novoj added a commit that referenced this issue Aug 5, 2024
@novoj
feat(#397): corrected port binding
2450b31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Khertys Khertys

Labels
breaking change Backward incompatible data model change enhancement New feature or request
Projects
None yet
Milestone
Beta
Development

No branches or pull requests
3 participants
@trustin @novoj @Khertys