fix(611): SortIndex handles BigDecimal in wrong way #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SortIndex internally holds Map, where key is the indexed value and value is the cardinality of the key. There is a normalizer implementation for certain types of keys (localized strings), but not for BigDecimal. But when the indexed values are BigDecimals and come in different forms - like `0` and `0.000` - they don't match in the map lookup unless normalized by `stripTrailingZeros()`. This causes the sort index to break during indexing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SortIndex internally holds Map, where key is the indexed value and value is the cardinality of the key. There is a normalizer implementation for certain types of keys (localized strings), but not for BigDecimal. But when the indexed values are BigDecimals and come in different forms - like
0and0.000- they don't match in the map lookup unless normalized bystripTrailingZeros(). This causes the sort index to break during indexing.