Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Changes #52

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Minor Changes #52

merged 10 commits into from
Oct 26, 2023

Conversation

JuliaPoo
Copy link
Collaborator

@JuliaPoo JuliaPoo commented Oct 26, 2023 •
edited
Loading

  1. Removed a bunch of warnings
  2. Removed dead code
  3. Correct debugging message
  4. Removed pass that removes duplicated _SET_IP
  5. Added PUSH_NULL to abstract interp
  6. Supported impure bytecode with sized operands
    • Changed some guards into impure
    • Supported 2 new types (PYNULL_TYPE, PYMETHOD_TYPE)

@JuliaPoo
Copy link
Collaborator Author

Don't merge yet, PUSH_NULL semantics can be improved

Fidget-Spinner
Fidget-Spinner reviewed Oct 26, 2023
View reviewed changes
Copy link
Owner

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, thanks.

Python/optimizer_analysis.c Outdated
@@ -1020,6 +990,14 @@ uop_abstract_interpret_single_inst(
break;
}

case PUSH_NULL: {
STACK_GROW(1);
_Py_UOpsSymbolicExpression *null_sym = _Py_UOpsSymbolicExpression_New(ctx, PUSH_NULL, 0, NULL, 0);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't be a singleton, because each time the originating_store will be different.

You should create a helper method to create singletons (ideally all their originating stores will be 0 or something).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okie I've implemented the Singletons. Note this requires PUSH_NULL to be labelled as "immutable"

@Fidget-Spinner Fidget-Spinner merged commit a2eb5e9 into ssa_graphs Oct 26, 2023
7 checks passed
@JuliaPoo JuliaPoo deleted the ssa_graphs_jules branch December 17, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JuliaPoo @Fidget-Spinner