DO NOT MERGE! Consistent main not ready yet. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't skip the first SDL_DisplayMode for each display (it's valid!) and fix bug where display modes were accumulating as iterating over displays (instead of registering just those modes supported by each)
We don't expect mode.{w, h} to be negative, nor that mode.refresh_rate
is not representable via double
My compiled SDL is 64-bit, but StepMania is still a 32-bit application. Thus, I'm getting linker errors. Either I have to compile SDL as a 32-bit application or I have to turn StepMania Mac OS X into a 64-bit one. Hopefully the latter task is easier.
Note that Mac OS X support is very experimental. It works...kind of. More work is necessary for full compliance, but it should not stop the PR from being merged in.
Allow Mac OS X to link with SDL.
This requires testing by other users. I did not get the expected results compared to Mac OS X. * In the Graphics/Sounds options menu, I did not see any special display. It was just Fullscreen and Windowed in that order. * Having the OpenGL renderer chosen instead of D3D caused a crash at the start. * I had to manually set some cmake variables to get it to build. See the directions on `CMake/Modules/FindSDL2.cmake`. It may be better to find a way to pre-load some of those variables.
If this is used instead of Mac's SMMain.mm, the following problems take place: * No loading window. * An unresponsive menu bar in the top of the screen (where all menu bars live on Mac OS X). * A forever bouncing StepMania icon, as if it's not done loading. * A lack of closing buttons. * A lack of title in the normal window title position. ...at least the keyboard worked? ......this is something I would like to see merged in, but it's not ready yet. I think the rest of the code has to use SDL2 first.
|
I'll state when this is ready for merging. Until then, keep this for historical context or something. |
Fighter19
force-pushed
the
SDL2Window
branch
2 times, most recently
from
e0b6066
to
2313f7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this is used instead of Mac's SMMain.mm, the following problems take place:
...at least the keyboard worked?
......this is something I would like to see merged in, but it's not ready yet. I think the rest of the code has to use SDL2 first.