Misc tidy up #77
Open
Misc tidy up #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes: - using the `std::fs::read_to_string` function, - using the `lines` method on a `BufReader`, - iterators directly rather than collecting everything in to a vec, - adding a couple of `debug_assert`s, - a little bit of general formatting (mixed tabs -> all spaces, correct indentation levels etc). `man os-release` specifies that `/usr/lib/os-release` should be used if `/etc/os-release` can't.
|
Merge conflict from #78 resolved :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm about to make a couple of PRs but, before that, I've spent a bit of time tidying a few things up. These are only minor things, including:
std::fs::read_to_stringfunction,linesmethod on aBufReader,debug_asserts,I've also added
/usr/lib/os-releaseas a fallback to/etc/os-releaseas specified in the man page.Thanks for your time :)