Support input where there is both standard input and arguments #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a `test:watch` for convenience
Allow custom `createInterface` implementation to be passed into `setupReadline` to be able to simulate no stdin.
Concatenates the two lists and puts stdin after args
| To make sure no `eslint` rules conflict with the prettier config, we have [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier). This can be run with: | ||
|
|
||
| npm run eslint-check | ||
|
|
There was a problem hiding this comment.
👍 For what its worth, there's some similar prose here: https://github.com/Financial-Times/github/blob/master/README.md#code-formatting-and-linting
|
THIS IS SO COOL 😎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than error when there are input repos from both standard input and arguments, just allow it and process both. Especially good for usage with
xargs. Also made the arbitrary call to process standard input after arguments, to mimicxargsusage.Main fix is in 1d14851, with other commits being clean up and refactoring steps. e1b0a68 also fixes an issue where we try to use
readlinewhen there is no standard input.Fixes #87
To test this
stdin
Returns stdin result
args
Returns arg result
stdin + args
Returns arg result, then stdin result (like
stdin + xargs + argsbelow)stdin + xargs
Returns stdin result
stdin + xargs + args
Returns arg result, then stdin result