Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support node 8 and 10 #97

Merged
merged 2 commits into from
May 10, 2019
Merged

Support node 8 and 10 #97

merged 2 commits into from
May 10, 2019

Conversation

taktran
Copy link
Contributor

@taktran taktran commented May 9, 2019

Set the default node version in .nvmrc to node 8, and build on ci for both node 8 and 10.

Fixes #79

@taktran taktran requested a review from a team May 9, 2019 16:37
jenniferemshepherd
jenniferemshepherd approved these changes May 10, 2019
View reviewed changes
Copy link
Contributor

@jenniferemshepherd jenniferemshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍬

@taktran taktran merged commit 85f07be into master May 10, 2019
@taktran taktran deleted the chores/use-node-8 branch May 10, 2019 09:24
@andygout andygout mentioned this pull request Oct 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenniferemshepherd jenniferemshepherd jenniferemshepherd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change node version for this project to 8.x.x
2 participants
@taktran @jenniferemshepherd