This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
Rhys/use hashed bundle #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* simpler? asset path calculation * restructred more completely
… rhys/use-hashed-bundle * 'master' of https://github.com/Financial-Times/n-ui: Rhys/deploy hashed assets (#986) tests run in prod env (#985) Make edition switcher URL configurable. (#981)
… rhys/use-hashed-bundle * 'master' of https://github.com/Financial-Times/n-ui: change conditional order for rebuild (#988)
wheresrhys
requested review from
i-like-robots,
kavanagh,
leggsimon and
leafrogers
leggsimon
approved these changes
Jun 26, 2017
kavanagh
suggested changes
Jun 26, 2017
build/app/download-assets.js
Outdated
| }) | ||
| .then(text => { | ||
| // if it's an empty string, something probably went wrong | ||
| if (!text.length) { | ||
| throw new Error('Fetched empty n-ui stylesheet'); | ||
| throw new Error('Fetched empty ${s3Name} from s3'); |
build/app/download-assets.js
Outdated
| .then(res => { | ||
| if (res.ok) { | ||
| return res.text(); | ||
| } | ||
| throw new Error('Failed to fetch n-ui stylesheet'); | ||
| throw new Error('Failed to download ${s3Name} from s3'); |
| const assetHashes = loadAssetHashesJson(`${directory}/public/asset-hashes.json`); | ||
| const nUiAssetHashes = loadAssetHashesJson(`${directory}/public/n-ui-asset-hashes.json`); | ||
| const nUiReleaseName = nUiManager.getReleaseName(directory); | ||
| const nUiUnhashedAssetsRoot = useLocalAppShell ? '/${appName}/n-ui/' : `//www.ft.com/__assets/n-ui/cached/${nUiReleaseName}/`; |
There was a problem hiding this comment.
should probably add some tests for dev mode. Not in this PR though as it's already epic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also contains a load of (hopefully) simplification of how paths to assets are built.