Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added region and prod/staging based configurations, deactivated the s… #28

Merged
merged 2 commits into from
Apr 10, 2018
Merged

Added region and prod/staging based configurations, deactivated the s… #28

merged 2 commits into from
Apr 10, 2018

Conversation

erdema-ft
Copy link
Contributor

…ticky flag for publish category in prod-us/staging-us for publishing cluster.

@erdema-ft
Added region and prod/staging based configurations, deactivated the s…
90e243f 
…ticky flag for publish category in prod-us/staging-us for publishing cluster.
efinlay24
efinlay24 reviewed Apr 10, 2018
View reviewed changes
Copy link
Contributor

@efinlay24 efinlay24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth explicitly setting:

      category.issticky: "false"

for the US clusters just to make it clear what the difference is?

@erdema-ft
Copy link
Contributor Author

Definitely, the intent would be more clear, agreed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 61.406% when pulling ffc6be5 on fix/sticky-publish-category into 4a4537f on master.

@kghatton
Copy link
Contributor

Should the generic upp-aggregate-healthcheck_publishing.yaml be removed as part of this PR?

@kghatton
Copy link
Contributor

Answering my own question: no, because these new files are only for prod/staging environments, we still need the generic file for the dev clusters.

@erdema-ft erdema-ft merged commit 60d05f7 into master Apr 10, 2018
@tamas-molnar tamas-molnar deleted the fix/sticky-publish-category branch April 24, 2018 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efinlay24 efinlay24 efinlay24 approved these changes

@kghatton kghatton kghatton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erdema-ft @coveralls @kghatton @efinlay24