Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add color band for tolerance #26

Merged
merged 4 commits into from
Jun 12, 2024
Merged

add color band for tolerance #26

merged 4 commits into from
Jun 12, 2024

Conversation

jx2014
Copy link
Contributor

@jx2014 jx2014 commented Jun 10, 2024

This change added the color band for tolerance.
Original script hardcold "grey" to the tolerance band.
This change adds the printing of color band for tolerance value of 0.25%, 0.5%, 1%, 2%, 5%, and 10%

@Finomnis
Copy link
Owner

Hey! Thanks for your contribution :)

I would like to keep this an optional change that does not affect default behavior, for two reasons:

  • many people (like me) don't really distinguish and want one bag for all tolerances
  • backwards compatibility - people that already printed some labels and want to add new values to their collection want to print the exact same stickers, just other resistor values. So I would keep the default the exact way it is now.

LabelGenerator.py Outdated Show resolved Hide resolved
LabelGenerator.py Outdated Show resolved Hide resolved
LabelGenerator.py Outdated Show resolved Hide resolved
@Finomnis
Copy link
Owner

Do you object to any of my changes?

@jx2014
Copy link
Contributor Author

jx2014 commented Jun 12, 2024

Looks good to me.

@jx2014 jx2014 closed this Jun 12, 2024
@jx2014 jx2014 reopened this Jun 12, 2024
Copy link
Contributor Author

@jx2014 jx2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works great.

@Finomnis
Copy link
Owner

Finomnis commented Jun 12, 2024

Also, sorry for reverting the readme change, it just didn't really fit into there, it was way more specific than the other points in the list. Hope you don't mind.

@Finomnis Finomnis merged commit 1f6a9aa into Finomnis:main Jun 12, 2024
15 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants