fix multisignature spec file error #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Multisignature is still encoded through Amino and prefix is added when encoded to Amino pubkey, but the prefix was not modified for ostracon, so multisig pubkey was not encoded correctly. Accordingly multisig address was not generated correctly. The problem was solved by modifying the prefix to match the ostracon.
3 tasks
3 tasks
zemyblue
reviewed
Apr 13, 2022
After change Amino prefix to fit with Ostracon, test codes crashed because every addresses and pubkeys in test code were made for former Amino prefix. Change addresses and pubkeys to Ostracon version.
generate new enigma bech32 pubkey from Ostracon secp256k1 pubkey
zemyblue
reviewed
Apr 15, 2022
Merged
dudong2
approved these changes
Apr 18, 2022
| signingInstruction.msgs, | ||
| signingInstruction.fee, | ||
| signingInstruction.memo, | ||
| // signingInstruction.sigBlockHeight, |
There was a problem hiding this comment.
How about removing the sigBlockHeight instead of commenting it out?
There was a problem hiding this comment.
I didn't know what sigBlockHeight was for, so I left it alone. I will remove it later.
| [address3, signature3], | ||
| [address4, signature4], | ||
| ]), | ||
| // signingInstruction.sigBlockHeight, |
| // On the composer's machine signing instructions are created. | ||
| // The composer does not need to be one of the signers. | ||
| const signingInstruction = await (async () => { | ||
| const client = await StargateClient.connect(simapp.tendermintUrl); |
There was a problem hiding this comment.
How about changing tendermint to ostracon?
There was a problem hiding this comment.
The name tendermint is being used in quite a few places, so I think it would be good to get rid of it at once later.
Merged
3 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multisignature is still encoded through Amino and prefix is added when encoded to Amino pubkey, but the prefix was not modified for ostracon, so multisig pubkey was not encoded correctly.
Accordingly multisig address was not generated correctly.
The problem was solved by modifying the prefix to match the ostracon.