refactor(x/bank): remove message events including sender attribute whose information is already present in the relevant events (backport #1066)
#1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc/v0.48.0-rcx #1093 +/- ##
==================================================
- Coverage 69.70% 69.69% -0.01%
==================================================
Files 642 642
Lines 67287 67277 -10
==================================================
- Hits 46902 46892 -10
Misses 18203 18203
Partials 2182 2182
|
zemyblue
approved these changes
Aug 24, 2023
jaeseung-bae
approved these changes
Aug 24, 2023
…whose information is already present in the relevant events (backport cosmos/cosmos#17273) (Finschia#1066) * refactor(x/bank): remove message events including `sender` attribute whose information is already present in the relevant events (#17273) * Update CHANGELOG.md * Update x/foundation tests * Update CHANGELOG.md * Update x/foundation tests * Update other tests * Apply suggestions from code review Update x/authz test * Use sdk.AttributeKeySender in x/bank type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch backports #1066 into v0.48.0 release candidate.
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml