Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(collection): add additional unittest of MsgIssueFT, MsgMintFT, MsgBurnFT #1131

Merged
merged 13 commits into from
Oct 6, 2023
Merged

test(collection): add additional unittest of MsgIssueFT, MsgMintFT, MsgBurnFT #1131

merged 13 commits into from
Oct 6, 2023

Conversation

zemyblue
Copy link
Member

@zemyblue zemyblue commented Sep 26, 2023 •
edited
Loading

Description

  • add more unittest for MsgIssueFT, MsgMintFT and MsgBurnFT of x/collection

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@zemyblue zemyblue added this to the v0.48.0 milestone Sep 26, 2023
@zemyblue zemyblue self-assigned this Sep 26, 2023
@codecov
Copy link

codecov bot commented Sep 26, 2023 •
edited
Loading

Codecov Report

Merging #1131 (4ce0bda) into rc/v0.48.0-rcx (e625d3d) will increase coverage by 0.00%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           rc/v0.48.0-rcx    #1131   +/-   ##
===============================================
  Coverage           69.77%   69.77%           
===============================================
  Files                 645      645           
  Lines               67482    67482           
===============================================
+ Hits                47084    47087    +3     
+ Misses              18211    18209    -2     
+ Partials             2187     2186    -1

see 1 file with indirect coverage changes

@zemyblue zemyblue marked this pull request as ready for review September 26, 2023 12:25
@tkxkd0159 tkxkd0159 changed the title chore: add additional unittest of x/collection(MsgIssueFT, MsgMintFT, MsgBurnFT) test: add additional unittest of x/collection(MsgIssueFT, MsgMintFT, MsgBurnFT) Sep 27, 2023
@tkxkd0159 tkxkd0159 changed the title test: add additional unittest of x/collection(MsgIssueFT, MsgMintFT, MsgBurnFT) test(collection): add additional unittest of MsgIssueFT, MsgMintFT, MsgBurnFT Sep 27, 2023
jaeseung-bae
jaeseung-bae previously approved these changes Oct 4, 2023
View reviewed changes
@zemyblue @tkxkd0159
chore: rearrange import packages in Update x/collection/keeper/msg_se…
4ce0bda 
…rver_test.go

Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
@zemyblue zemyblue merged commit 1519bae into Finschia:rc/v0.48.0-rcx Oct 6, 2023
37 checks passed
@zemyblue zemyblue deleted the feat/add_unittest_collection_tx1 branch October 6, 2023 10:02
@zemyblue zemyblue mentioned this pull request Oct 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaeseung-bae jaeseung-bae jaeseung-bae approved these changes

@tkxkd0159 tkxkd0159 tkxkd0159 approved these changes

Assignees

@zemyblue zemyblue

Labels
C:x/collection
Projects
None yet
Milestone
v0.48.0
Development

Successfully merging this pull request may close these issues.
3 participants
@zemyblue @tkxkd0159 @jaeseung-bae