Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add idle-timeout to rest server and rpc server config #114

Merged
merged 5 commits into from
Apr 5, 2021
Merged

feat: Add idle-timeout to rest server and rpc server config #114

merged 5 commits into from
Apr 5, 2021

Conversation

egonspace
Copy link

@egonspace egonspace commented Apr 5, 2021 •
edited
Loading

Description

Applying #42 to ebony branch.
Linked issue: https://github.com/line/lbm/issues/1137

closes: #XXXX

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to CHANGELOG_PENDING.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@egonspace egonspace self-assigned this Apr 5, 2021
@egonspace egonspace added this to the Initail ebony milestone Apr 5, 2021
@egonspace egonspace changed the title chore: add to rest server feat: Add idle-timeout to rest server and rpc server config Apr 5, 2021
wetcod
wetcod approved these changes Apr 5, 2021
View reviewed changes
Copy link
Contributor

@wetcod wetcod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@egonspace egonspace merged commit 8d9acf5 into v2/develop Apr 5, 2021
brew0722 pushed a commit that referenced this pull request Apr 19, 2021
@ethanfrey
Merge pull request #114 from CosmWasm/document-integration
4ab0544 
Document integration
@egonspace egonspace deleted the egon/v2/feat/apply_42 branch May 27, 2021 04:43
@zemyblue zemyblue mentioned this pull request Nov 20, 2023
Merged
5 tasks
@jaeseung-bae jaeseung-bae mentioned this pull request Dec 26, 2023
Open
96 tasks
@tkxkd0159 tkxkd0159 mentioned this pull request Jan 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jinsan-line jinsan-line jinsan-line approved these changes

@wetcod wetcod wetcod approved these changes

@kukugi kukugi Awaiting requested review from kukugi

@iproudhon iproudhon Awaiting requested review from iproudhon

Assignees

@egonspace egonspace

Labels
None yet
Projects
None yet
Milestone
Initail ebony
Development

Successfully merging this pull request may close these issues.
3 participants
@egonspace @wetcod @jinsan-line