Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement fswap module's genesis and params #1339

Merged
merged 27 commits into from
Apr 25, 2024

Conversation

170210
Copy link
Contributor

@170210 170210 commented Apr 19, 2024

Description

  • implement genesis related functions
  • implement params & swapped related functions
  • add genesis IT & UT tests
  • add fswap module into baseApp

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 78.40000% with 27 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (pjdp1@6afe633). Click here to learn what that means.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             pjdp1    #1339   +/-   ##
========================================
  Coverage         ?   70.34%           
========================================
  Files            ?      657           
  Lines            ?    54977           
  Branches         ?        0           
========================================
  Hits             ?    38675           
  Misses           ?    14119           
  Partials         ?     2183           
Files Coverage Δ
simapp/app.go 79.68% <100.00%> (ø)
x/fswap/keeper/keeper.go 77.77% <100.00%> (ø)
x/fswap/types/genesis.go 100.00% <100.00%> (ø)
x/fswap/types/keys.go 0.00% <ø> (ø)
x/fswap/types/params.go 75.00% <100.00%> (ø)
x/fswap/simulation/genesis.go 92.59% <92.59%> (ø)
x/fswap/keeper/fswap.go 73.33% <73.33%> (ø)
x/fswap/keeper/genesis.go 55.55% <55.55%> (ø)
x/fswap/types/config.go 0.00% <0.00%> (ø)
x/fswap/types/fswap.go 79.16% <79.16%> (ø)
... and 1 more

Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 self-assigned this Apr 19, 2024
@170210 170210 marked this pull request as ready for review April 19, 2024 08:46
CHANGELOG.md Outdated Show resolved Hide resolved
x/fswap/types/params.go Outdated Show resolved Hide resolved
x/fswap/keeper/genesis.go Outdated Show resolved Hide resolved
@170210 170210 changed the title feat: implement genesis and params feat: implement genesis and params of fswap module Apr 23, 2024
@170210 170210 changed the title feat: implement genesis and params of fswap module feat: implement fswap module's genesis and params Apr 23, 2024
Signed-off-by: 170210 <j170210@icloud.com>
x/fswap/types/genesis.go Outdated Show resolved Hide resolved
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should consider making the swappable amount as a parameter.

Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 requested a review from 0Tech April 24, 2024 04:26
x/fswap/types/keys.go Outdated Show resolved Hide resolved
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
x/fswap/types/keys.go Outdated Show resolved Hide resolved
x/fswap/module_simulation.go Outdated Show resolved Hide resolved
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Signed-off-by: 170210 <j170210@icloud.com>
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@170210 170210 merged commit 52a3f83 into Finschia:pjdp1 Apr 25, 2024
33 checks passed
jaeseung-bae added a commit that referenced this pull request May 3, 2024
* feat: initialize fswap module (#1336)

* feat: initial fswap module

Signed-off-by: 170210 <j170210@icloud.com>

* chore: correct dependencies

Signed-off-by: 170210 <j170210@icloud.com>

* chore: remove unuse files

Signed-off-by: 170210 <j170210@icloud.com>

* feat: add proto files

Signed-off-by: 170210 <j170210@icloud.com>

* chore: make proto-gen

Signed-off-by: 170210 <j170210@icloud.com>

* chore: fix compile error

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add new field in params proto

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* feat: add query&tx commands of fswap module

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

* docs: update CHANGLOG.md

Signed-off-by: 170210 <j170210@icloud.com>

* docs: fix error docs

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix consensusversion

Signed-off-by: 170210 <j170210@icloud.com>

* fix: remove route,type&getSignBytes in msgs.go

Signed-off-by: 170210 <j170210@icloud.com>

* fix: update proto files

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix NewKeeper

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>

* feat: implement fswap module's genesis and params (#1339)

* feat: implement genesis related functions

Signed-off-by: 170210 <j170210@icloud.com>

* chore: use mockgen

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add tests

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add subspace in paramsKeeper

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for test errors

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix appmodulebasic

Signed-off-by: 170210 <j170210@icloud.com>

* chore: update CHANGLOG.md

Signed-off-by: 170210 <j170210@icloud.com>

* fix: use configuration instead of params

Signed-off-by: 170210 <j170210@icloud.com>

* chore: refactor new&default fswapped

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add total_supply into genesisStatus & remove calculate logic

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix module_simulation

Signed-off-by: 170210 <j170210@icloud.com>

* fix: set swappableNewCoinDenom as params

Signed-off-by: 170210 <j170210@icloud.com>

* fix: change total_supply name to swappableNewCoinAmount

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: use io/collection to generate key

Signed-off-by: 170210 <j170210@icloud.com>

* Revert "fix: use io/collection to generate key"

This reverts commit e42e064.

* fix: change sdk.Coin to sdk.Int

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: remote unnecessary codes

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add validate for swappable new coin

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add randomizedGenState

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix error doc

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: change proto message fields' name

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>

* feat: initialize fbridge module (#1340)

* initialize fbridge module

* add all proto files for fbridge

* add missing proto files

* initialize module structure

* modify proto based on discussion

* add codec

* add CHANGELOG

* modify UpdateRole feature

* feat: fbridge transfer (#1347)

* impl bridge transfer tx/query

* add CLI

* feat: save sequence for every bridge request (#1351)

* feat: add SeqToBlocknum

* add CHANGELOG

* add query bound for SeqToBlocknums

* feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345)

* refactor: fswap module's proto

Signed-off-by: 170210 <j170210@icloud.com>

* refactor: remove config&params and modify genesis

Signed-off-by: 170210 <j170210@icloud.com>

* refactor: use gov/proposal to change fswapInit

Signed-off-by: 170210 <j170210@icloud.com>

* chore: fix simulation

Signed-off-by: 170210 <j170210@icloud.com>

* chore: correct query cli

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add query for test

Signed-off-by: 170210 <j170210@icloud.com>

* chore: lint fix

* chore: fix for tx cli

* chore: update proto

* chore: update genesis logic

* chore: add basic tx and queries

* chore: rename fswap to swap

* chore: change old/new to from/to

* chore: clean-up

* chore: clean errors and rename

* chore: update proto

* chore: clean unnecessary member variables

* chore: update proto, introduce config, clean code

* chore: remove redundant denom validation

* chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2

* chore: apply feedbacks

* chore: fix some

* chore: fix for initGenesis

* chore: apply feedbacks

* chore: update changelog

* chore: remove redundant logic

* chore: update error doc

* chore: update proto and logic to accept bank.Metadata

* chore: add query to get all the swaps

* chore: change swap_multiple to swap_rate

* chore: disallow updating existing denom metadata with different values

* chore: fix for calcSwap logic

* chore: extract CalcSwap to function

* chore: add missing query cmd

* chore: fix for proposal cli

* chore: fix for init timing

* chore: fix query cli

* chore: fix to prevent generating swap more than MaxSwaps

* fix: add missing call validateBasic for proposal

* fix:

* chore: change error type for temporal test-pass

* chore: fix for make-swap-proposal update

* chore: fix to check swap count after increase in order not to make more than limit

* chore: prevent any proposal with different denom

* chore: change amount cap type

* chore: fix codec-related parts

* chore: minor change for convert to-coin-amount-cap

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
jaeseung-bae added a commit to jaeseung-bae/finschia-sdk that referenced this pull request May 7, 2024
* feat: initialize fswap module (Finschia#1336)

* feat: initial fswap module

Signed-off-by: 170210 <j170210@icloud.com>

* chore: correct dependencies

Signed-off-by: 170210 <j170210@icloud.com>

* chore: remove unuse files

Signed-off-by: 170210 <j170210@icloud.com>

* feat: add proto files

Signed-off-by: 170210 <j170210@icloud.com>

* chore: make proto-gen

Signed-off-by: 170210 <j170210@icloud.com>

* chore: fix compile error

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add new field in params proto

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* feat: add query&tx commands of fswap module

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

* docs: update CHANGLOG.md

Signed-off-by: 170210 <j170210@icloud.com>

* docs: fix error docs

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix consensusversion

Signed-off-by: 170210 <j170210@icloud.com>

* fix: remove route,type&getSignBytes in msgs.go

Signed-off-by: 170210 <j170210@icloud.com>

* fix: update proto files

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix NewKeeper

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>

* feat: implement fswap module's genesis and params (Finschia#1339)

* feat: implement genesis related functions

Signed-off-by: 170210 <j170210@icloud.com>

* chore: use mockgen

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add tests

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add subspace in paramsKeeper

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for test errors

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix appmodulebasic

Signed-off-by: 170210 <j170210@icloud.com>

* chore: update CHANGLOG.md

Signed-off-by: 170210 <j170210@icloud.com>

* fix: use configuration instead of params

Signed-off-by: 170210 <j170210@icloud.com>

* chore: refactor new&default fswapped

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add total_supply into genesisStatus & remove calculate logic

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix module_simulation

Signed-off-by: 170210 <j170210@icloud.com>

* fix: set swappableNewCoinDenom as params

Signed-off-by: 170210 <j170210@icloud.com>

* fix: change total_supply name to swappableNewCoinAmount

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: use io/collection to generate key

Signed-off-by: 170210 <j170210@icloud.com>

* Revert "fix: use io/collection to generate key"

This reverts commit e42e064.

* fix: change sdk.Coin to sdk.Int

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: remote unnecessary codes

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add validate for swappable new coin

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add randomizedGenState

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix error doc

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: change proto message fields' name

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>

* feat: initialize fbridge module (Finschia#1340)

* initialize fbridge module

* add all proto files for fbridge

* add missing proto files

* initialize module structure

* modify proto based on discussion

* add codec

* add CHANGELOG

* modify UpdateRole feature

* feat: fbridge transfer (Finschia#1347)

* impl bridge transfer tx/query

* add CLI

* feat: save sequence for every bridge request (Finschia#1351)

* feat: add SeqToBlocknum

* add CHANGELOG

* add query bound for SeqToBlocknums

* feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (Finschia#1345)

* refactor: fswap module's proto

Signed-off-by: 170210 <j170210@icloud.com>

* refactor: remove config&params and modify genesis

Signed-off-by: 170210 <j170210@icloud.com>

* refactor: use gov/proposal to change fswapInit

Signed-off-by: 170210 <j170210@icloud.com>

* chore: fix simulation

Signed-off-by: 170210 <j170210@icloud.com>

* chore: correct query cli

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add query for test

Signed-off-by: 170210 <j170210@icloud.com>

* chore: lint fix

* chore: fix for tx cli

* chore: update proto

* chore: update genesis logic

* chore: add basic tx and queries

* chore: rename fswap to swap

* chore: change old/new to from/to

* chore: clean-up

* chore: clean errors and rename

* chore: update proto

* chore: clean unnecessary member variables

* chore: update proto, introduce config, clean code

* chore: remove redundant denom validation

* chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2

* chore: apply feedbacks

* chore: fix some

* chore: fix for initGenesis

* chore: apply feedbacks

* chore: update changelog

* chore: remove redundant logic

* chore: update error doc

* chore: update proto and logic to accept bank.Metadata

* chore: add query to get all the swaps

* chore: change swap_multiple to swap_rate

* chore: disallow updating existing denom metadata with different values

* chore: fix for calcSwap logic

* chore: extract CalcSwap to function

* chore: add missing query cmd

* chore: fix for proposal cli

* chore: fix for init timing

* chore: fix query cli

* chore: fix to prevent generating swap more than MaxSwaps

* fix: add missing call validateBasic for proposal

* fix:

* chore: change error type for temporal test-pass

* chore: fix for make-swap-proposal update

* chore: fix to check swap count after increase in order not to make more than limit

* chore: prevent any proposal with different denom

* chore: change amount cap type

* chore: fix codec-related parts

* chore: minor change for convert to-coin-amount-cap

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
jaeseung-bae added a commit to jaeseung-bae/finschia-sdk that referenced this pull request May 7, 2024
* feat: initialize fswap module (Finschia#1336)

* feat: initial fswap module

Signed-off-by: 170210 <j170210@icloud.com>

* chore: correct dependencies

Signed-off-by: 170210 <j170210@icloud.com>

* chore: remove unuse files

Signed-off-by: 170210 <j170210@icloud.com>

* feat: add proto files

Signed-off-by: 170210 <j170210@icloud.com>

* chore: make proto-gen

Signed-off-by: 170210 <j170210@icloud.com>

* chore: fix compile error

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add new field in params proto

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* feat: add query&tx commands of fswap module

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

* docs: update CHANGLOG.md

Signed-off-by: 170210 <j170210@icloud.com>

* docs: fix error docs

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix consensusversion

Signed-off-by: 170210 <j170210@icloud.com>

* fix: remove route,type&getSignBytes in msgs.go

Signed-off-by: 170210 <j170210@icloud.com>

* fix: update proto files

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix NewKeeper

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>

* feat: implement fswap module's genesis and params (Finschia#1339)

* feat: implement genesis related functions

Signed-off-by: 170210 <j170210@icloud.com>

* chore: use mockgen

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add tests

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add subspace in paramsKeeper

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for test errors

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix appmodulebasic

Signed-off-by: 170210 <j170210@icloud.com>

* chore: update CHANGLOG.md

Signed-off-by: 170210 <j170210@icloud.com>

* fix: use configuration instead of params

Signed-off-by: 170210 <j170210@icloud.com>

* chore: refactor new&default fswapped

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add total_supply into genesisStatus & remove calculate logic

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix module_simulation

Signed-off-by: 170210 <j170210@icloud.com>

* fix: set swappableNewCoinDenom as params

Signed-off-by: 170210 <j170210@icloud.com>

* fix: change total_supply name to swappableNewCoinAmount

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: use io/collection to generate key

Signed-off-by: 170210 <j170210@icloud.com>

* Revert "fix: use io/collection to generate key"

This reverts commit e42e064.

* fix: change sdk.Coin to sdk.Int

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: remote unnecessary codes

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add validate for swappable new coin

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add randomizedGenState

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix error doc

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: change proto message fields' name

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>

* feat: initialize fbridge module (Finschia#1340)

* initialize fbridge module

* add all proto files for fbridge

* add missing proto files

* initialize module structure

* modify proto based on discussion

* add codec

* add CHANGELOG

* modify UpdateRole feature

* feat: fbridge transfer (Finschia#1347)

* impl bridge transfer tx/query

* add CLI

* feat: save sequence for every bridge request (Finschia#1351)

* feat: add SeqToBlocknum

* add CHANGELOG

* add query bound for SeqToBlocknums

* feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (Finschia#1345)

* refactor: fswap module's proto

Signed-off-by: 170210 <j170210@icloud.com>

* refactor: remove config&params and modify genesis

Signed-off-by: 170210 <j170210@icloud.com>

* refactor: use gov/proposal to change fswapInit

Signed-off-by: 170210 <j170210@icloud.com>

* chore: fix simulation

Signed-off-by: 170210 <j170210@icloud.com>

* chore: correct query cli

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add query for test

Signed-off-by: 170210 <j170210@icloud.com>

* chore: lint fix

* chore: fix for tx cli

* chore: update proto

* chore: update genesis logic

* chore: add basic tx and queries

* chore: rename fswap to swap

* chore: change old/new to from/to

* chore: clean-up

* chore: clean errors and rename

* chore: update proto

* chore: clean unnecessary member variables

* chore: update proto, introduce config, clean code

* chore: remove redundant denom validation

* chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2

* chore: apply feedbacks

* chore: fix some

* chore: fix for initGenesis

* chore: apply feedbacks

* chore: update changelog

* chore: remove redundant logic

* chore: update error doc

* chore: update proto and logic to accept bank.Metadata

* chore: add query to get all the swaps

* chore: change swap_multiple to swap_rate

* chore: disallow updating existing denom metadata with different values

* chore: fix for calcSwap logic

* chore: extract CalcSwap to function

* chore: add missing query cmd

* chore: fix for proposal cli

* chore: fix for init timing

* chore: fix query cli

* chore: fix to prevent generating swap more than MaxSwaps

* fix: add missing call validateBasic for proposal

* fix:

* chore: change error type for temporal test-pass

* chore: fix for make-swap-proposal update

* chore: fix to check swap count after increase in order not to make more than limit

* chore: prevent any proposal with different denom

* chore: change amount cap type

* chore: fix codec-related parts

* chore: minor change for convert to-coin-amount-cap

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
jaeseung-bae added a commit that referenced this pull request May 7, 2024
* feat: introduce new modules(fswap, fbridge) (#1352)

* feat: initialize fswap module (#1336)

* feat: initial fswap module

Signed-off-by: 170210 <j170210@icloud.com>

* chore: correct dependencies

Signed-off-by: 170210 <j170210@icloud.com>

* chore: remove unuse files

Signed-off-by: 170210 <j170210@icloud.com>

* feat: add proto files

Signed-off-by: 170210 <j170210@icloud.com>

* chore: make proto-gen

Signed-off-by: 170210 <j170210@icloud.com>

* chore: fix compile error

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add new field in params proto

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* feat: add query&tx commands of fswap module

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

* docs: update CHANGLOG.md

Signed-off-by: 170210 <j170210@icloud.com>

* docs: fix error docs

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix consensusversion

Signed-off-by: 170210 <j170210@icloud.com>

* fix: remove route,type&getSignBytes in msgs.go

Signed-off-by: 170210 <j170210@icloud.com>

* fix: update proto files

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix NewKeeper

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for comment

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>

* feat: implement fswap module's genesis and params (#1339)

* feat: implement genesis related functions

Signed-off-by: 170210 <j170210@icloud.com>

* chore: use mockgen

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add tests

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add subspace in paramsKeeper

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix for test errors

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix appmodulebasic

Signed-off-by: 170210 <j170210@icloud.com>

* chore: update CHANGLOG.md

Signed-off-by: 170210 <j170210@icloud.com>

* fix: use configuration instead of params

Signed-off-by: 170210 <j170210@icloud.com>

* chore: refactor new&default fswapped

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add total_supply into genesisStatus & remove calculate logic

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix module_simulation

Signed-off-by: 170210 <j170210@icloud.com>

* fix: set swappableNewCoinDenom as params

Signed-off-by: 170210 <j170210@icloud.com>

* fix: change total_supply name to swappableNewCoinAmount

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: use io/collection to generate key

Signed-off-by: 170210 <j170210@icloud.com>

* Revert "fix: use io/collection to generate key"

This reverts commit e42e064.

* fix: change sdk.Coin to sdk.Int

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: remote unnecessary codes

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add validate for swappable new coin

Signed-off-by: 170210 <j170210@icloud.com>

* fix: add randomizedGenState

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix error doc

Signed-off-by: 170210 <j170210@icloud.com>

* fix: fix lint

Signed-off-by: 170210 <j170210@icloud.com>

* fix: change proto message fields' name

Signed-off-by: 170210 <j170210@icloud.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>

* feat: initialize fbridge module (#1340)

* initialize fbridge module

* add all proto files for fbridge

* add missing proto files

* initialize module structure

* modify proto based on discussion

* add codec

* add CHANGELOG

* modify UpdateRole feature

* feat: fbridge transfer (#1347)

* impl bridge transfer tx/query

* add CLI

* feat: save sequence for every bridge request (#1351)

* feat: add SeqToBlocknum

* add CHANGELOG

* add query bound for SeqToBlocknums

* feat: fswap module's basic functionality(MsgSwap, MsgSwapAll, Query, Proposal) (#1345)

* refactor: fswap module's proto

Signed-off-by: 170210 <j170210@icloud.com>

* refactor: remove config&params and modify genesis

Signed-off-by: 170210 <j170210@icloud.com>

* refactor: use gov/proposal to change fswapInit

Signed-off-by: 170210 <j170210@icloud.com>

* chore: fix simulation

Signed-off-by: 170210 <j170210@icloud.com>

* chore: correct query cli

Signed-off-by: 170210 <j170210@icloud.com>

* chore: add query for test

Signed-off-by: 170210 <j170210@icloud.com>

* chore: lint fix

* chore: fix for tx cli

* chore: update proto

* chore: update genesis logic

* chore: add basic tx and queries

* chore: rename fswap to swap

* chore: change old/new to from/to

* chore: clean-up

* chore: clean errors and rename

* chore: update proto

* chore: clean unnecessary member variables

* chore: update proto, introduce config, clean code

* chore: remove redundant denom validation

* chore: remove cache-like operation, rename swap proposal in proto, errors start with number 2

* chore: apply feedbacks

* chore: fix some

* chore: fix for initGenesis

* chore: apply feedbacks

* chore: update changelog

* chore: remove redundant logic

* chore: update error doc

* chore: update proto and logic to accept bank.Metadata

* chore: add query to get all the swaps

* chore: change swap_multiple to swap_rate

* chore: disallow updating existing denom metadata with different values

* chore: fix for calcSwap logic

* chore: extract CalcSwap to function

* chore: add missing query cmd

* chore: fix for proposal cli

* chore: fix for init timing

* chore: fix query cli

* chore: fix to prevent generating swap more than MaxSwaps

* fix: add missing call validateBasic for proposal

* fix:

* chore: change error type for temporal test-pass

* chore: fix for make-swap-proposal update

* chore: fix to check swap count after increase in order not to make more than limit

* chore: prevent any proposal with different denom

* chore: change amount cap type

* chore: fix codec-related parts

* chore: minor change for convert to-coin-amount-cap

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: jaeseung.bae <jaeseung.bae@linecorp.com>

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>

* chore: lint fix

---------

Signed-off-by: 170210 <j170210@icloud.com>
Co-authored-by: 170210 <85928898+170210@users.noreply.github.com>
Co-authored-by: Jayden Lee <41176085+tkxkd0159@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants