Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy from modules #255

Merged
merged 1 commit into from
Jun 24, 2021
Merged

Conversation

egonspace
Copy link

@egonspace egonspace commented Jun 24, 2021

Description

  • I removed legacy module (0.36 ~ 0.40 modules) and migrate command
  • I wanted to remove SIGN_MODE_LEGACY_AMINO_JSON as well but I couldn't because it's used for multisig and json tx response.
  • This makes lfb to be updated. I'll make a PR for it.

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@786df84). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #255   +/-   ##
=======================================
  Coverage        ?   53.45%           
=======================================
  Files           ?      639           
  Lines           ?    46833           
  Branches        ?        0           
=======================================
  Hits            ?    25036           
  Misses          ?    18954           
  Partials        ?     2843           

@egonspace egonspace merged commit 9bcea92 into main Jun 24, 2021
@egonspace egonspace deleted the egon/refactor/remove_legacy branch June 24, 2021 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants