Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: restructure x/consortium #493

Merged
merged 19 commits into from
Apr 28, 2022
Merged

refactor: restructure x/consortium #493

merged 19 commits into from
Apr 28, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Mar 31, 2022

Description

closes: #489

Motivation and context

Refer to #489.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes. [no need]
  • I have updated the documentation accordingly. [no need]
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml [no need]

@0Tech 0Tech self-assigned this Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #493 (15f6bbc) into main (396a1fe) will increase coverage by 0.04%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #493      +/-   ##
==========================================
+ Coverage   56.75%   56.80%   +0.04%     
==========================================
  Files         777      777              
  Lines       83389    83344      -45     
==========================================
+ Hits        47331    47341      +10     
+ Misses      33004    32951      -53     
+ Partials     3054     3052       -2     
Impacted Files Coverage Δ
x/consortium/keeper/genesis.go 19.23% <19.23%> (ø)
x/consortium/keeper/keeper.go 90.00% <66.66%> (ø)
x/consortium/keeper/proposal.go 83.33% <83.33%> (ø)
simapp/app.go 86.94% <100.00%> (ø)
x/consortium/client/testutil/grpc.go 94.64% <100.00%> (ø)
x/consortium/client/testutil/suite.go 100.00% <100.00%> (ø)
x/consortium/keeper/grpc_query.go 65.90% <100.00%> (+3.40%) ⬆️
x/consortium/keeper/handler.go 58.33% <100.00%> (ø)
x/consortium/keeper/keys.go 100.00% <100.00%> (ø)
x/consortium/keeper/params.go 100.00% <100.00%> (ø)
... and 4 more

@0Tech
Copy link
Collaborator Author

0Tech commented Mar 31, 2022

I should add tests to increase the coverage. Let me handle it on the separate issue later.

@0Tech 0Tech marked this pull request as ready for review March 31, 2022 06:28
@0Tech 0Tech requested review from dudong2 and zemyblue March 31, 2022 06:28
x/consortium/genesis.go Outdated Show resolved Hide resolved
x/consortium/keeper/genesis.go Show resolved Hide resolved
x/consortium/keeper/keys.go Show resolved Hide resolved
x/consortium/genesis.go Outdated Show resolved Hide resolved
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit eae8824 into Finschia:main Apr 28, 2022
@0Tech 0Tech deleted the consortium branch April 28, 2022 09:43
@0Tech 0Tech restored the consortium branch April 28, 2022 12:43
@0Tech 0Tech deleted the consortium branch May 24, 2022 02:50
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
@0Tech 0Tech added the C:x/foundation x/foundation module label Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor x/consortium
3 participants