Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix bugs in x/collection MsgModify #647

Merged
merged 7 commits into from
Aug 23, 2022
Merged

fix: fix bugs in x/collection MsgModify #647

merged 7 commits into from
Aug 23, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Aug 22, 2022 •
edited
Loading

Description

This patch addresses the following issues:

  • MsgModify updates the corresponding value of the attribute with the key, not with the value.
  • MsgModify updates unintended attribute.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the A: bug Something isn't working label Aug 22, 2022
@0Tech 0Tech self-assigned this Aug 22, 2022
@0Tech 0Tech changed the title fix: fix a bug in x/collection MsgModify fix: fix bugs in x/collection MsgModify Aug 22, 2022
@0Tech 0Tech requested review from dudong2 and zemyblue August 22, 2022 04:40
@codecov
Copy link

codecov bot commented Aug 22, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (rc/v0.46.0-rc6@620e456). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             rc/v0.46.0-rc6     #647   +/-   ##
=================================================
  Coverage                  ?   59.73%           
=================================================
  Files                     ?      811           
  Lines                     ?    94524           
  Branches                  ?        0           
=================================================
  Hits                      ?    56467           
  Misses                    ?    34597           
  Partials                  ?     3460

@0Tech 0Tech marked this pull request as ready for review August 22, 2022 05:40
@0Tech 0Tech merged commit 45ac9cc into Finschia:rc/v0.46.0-rc6 Aug 23, 2022
@0Tech 0Tech deleted the collection_modify_fix branch August 23, 2022 04:21
@0Tech 0Tech mentioned this pull request Aug 23, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dudong2 dudong2 dudong2 approved these changes

@zemyblue zemyblue zemyblue approved these changes

Assignees

@0Tech 0Tech

Labels
A: bug Something isn't working C:x/collection
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0Tech @zemyblue @dudong2