Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix max gas validation #673

Merged
merged 6 commits into from
Sep 21, 2022
Merged

fix: fix max gas validation #673

merged 6 commits into from
Sep 21, 2022

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Sep 14, 2022

Description

This patch fixes bugs relevant to #48. We should revisit this and #48. Please refer to tendermint/tendermint#6740.

Related: Finschia/ostracon#158

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech added the A: bug Something isn't working label Sep 14, 2022
@0Tech 0Tech self-assigned this Sep 14, 2022
@codecov
Copy link

codecov bot commented Sep 14, 2022

Codecov Report

Merging #673 (fd0be15) into rc/v0.46.0-rc8 (e19f863) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##           rc/v0.46.0-rc8     #673      +/-   ##
==================================================
+ Coverage           60.44%   60.47%   +0.02%     
==================================================
  Files                 826      826              
  Lines               96128    96128              
==================================================
+ Hits                58108    58133      +25     
+ Misses              34520    34495      -25     
  Partials             3500     3500              
Impacted Files Coverage Δ
baseapp/abci.go 62.40% <100.00%> (ø)
baseapp/baseapp.go 80.36% <100.00%> (+0.04%) ⬆️
x/auth/ante/setup.go 81.13% <100.00%> (+12.61%) ⬆️
x/collection/collection.go 78.57% <0.00%> (-1.79%) ⬇️
x/foundation/foundation.go 73.64% <0.00%> (-0.37%) ⬇️
x/token/msgs.go 30.45% <0.00%> (ø)
x/wasm/keeper/keeper.go 86.16% <0.00%> (+0.36%) ⬆️
x/collection/msgs.go 41.29% <0.00%> (+1.85%) ⬆️
x/foundation/msgs.go 43.26% <0.00%> (+1.92%) ⬆️
x/token/validation.go 87.27% <0.00%> (+9.09%) ⬆️
... and 1 more

@0Tech 0Tech marked this pull request as ready for review September 14, 2022 11:28
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unittest or integrate test about this bug?

@0Tech 0Tech requested a review from zemyblue September 21, 2022 04:54
Copy link
Member

@zemyblue zemyblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0Tech 0Tech merged commit 30cd552 into Finschia:rc/v0.46.0-rc8 Sep 21, 2022
@0Tech 0Tech deleted the maxgas branch September 21, 2022 09:17
0Tech added a commit that referenced this pull request Oct 25, 2022
* Run the validation on checkTx

* Set consensus params

* Update CHANGELOG.md

* Update workflows

* Add tests to cover ReCheckTx of validateMaxGas

* Add tests to cover consensus parameter updates
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
@0Tech 0Tech mentioned this pull request Feb 13, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants