-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix max gas validation #673
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## rc/v0.46.0-rc8 #673 +/- ##
==================================================
+ Coverage 60.44% 60.47% +0.02%
==================================================
Files 826 826
Lines 96128 96128
==================================================
+ Hits 58108 58133 +25
+ Misses 34520 34495 -25
Partials 3500 3500
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a unittest or integrate test about this bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This patch fixes bugs relevant to #48. We should revisit this and #48. Please refer to tendermint/tendermint#6740.
Related: Finschia/ostracon#158
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml