fix: fix to prevent external filesystem dependency of simulations #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
==========================================
- Coverage 62.01% 61.97% -0.05%
==========================================
Files 874 877 +3
Lines 98614 98764 +150
==========================================
+ Hits 61156 61206 +50
- Misses 33841 33938 +97
- Partials 3617 3620 +3
|
zemyblue
reviewed
Oct 5, 2022
zemyblue
reviewed
Oct 12, 2022
da1suk8
changed the title
da1suk8
changed the title
da1suk8
changed the title
zemyblue
reviewed
Oct 14, 2022
x/wasm/simulation/operations.go
Outdated
Comment on lines
67
to
68
| if err != nil { | ||
| panic(err) |
There was a problem hiding this comment.
How about adding the unittest of this lines?
There was a problem hiding this comment.
This is dead code, so I deleted it.
zemyblue
approved these changes
Oct 17, 2022
tnasu
approved these changes
Oct 18, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed to prevent external filesystem dependency of simulation.
The code has been modified as follows.
WeightedOperations returns a function, so I added a test to compare types.
Motivation and context
Because if the path is not resolved correctly or the file is not found, the call may fail and execution may panic.
How has this been tested?
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml