Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow up to one direct sign in multi sign tx #708

Merged
merged 2 commits into from
Oct 16, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Oct 12, 2022

Description

In the current multi sign tx, if there is even one direct mode sign, the sign will fail.
It changed to allows one direct sign even multi sign tx .

ref. https://github.com/cosmos/cosmos-sdk/pull/10683/files
closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@dudong2 dudong2 added the A: bug Something isn't working label Oct 12, 2022
@dudong2 dudong2 self-assigned this Oct 12, 2022
@dudong2 dudong2 removed the A: bug Something isn't working label Oct 12, 2022
@dudong2 dudong2 added the A: bug Something isn't working label Oct 12, 2022
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Merging #708 (b55f8ef) into main (289ca6b) will increase coverage by 0.02%.
The diff coverage is 63.15%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
+ Coverage   61.83%   61.86%   +0.02%     
==========================================
  Files         874      874              
  Lines       98557    98585      +28     
==========================================
+ Hits        60944    60986      +42     
- Misses      33982    33988       +6     
+ Partials     3631     3611      -20     
Impacted Files Coverage Δ
client/tx/tx.go 33.22% <62.16%> (+2.81%) ⬆️
x/auth/client/testutil/suite.go 96.61% <100.00%> (ø)
x/wasm/keeper/keeper.go 85.80% <0.00%> (-0.37%) ⬇️
x/token/msgs.go 34.51% <0.00%> (ø)
x/collection/msgs.go 43.33% <0.00%> (+3.33%) ⬆️
x/token/validation.go 90.90% <0.00%> (+18.18%) ⬆️

@dudong2 dudong2 changed the title fix: allow one direct sign in multi sign tx fix: allow up to one direct sign in multi sign tx Oct 12, 2022
@tkxkd0159 tkxkd0159 self-requested a review October 14, 2022 01:26
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 2eb6fd9 into Finschia:main Oct 16, 2022
@dudong2 dudong2 deleted the dudong2/fix/TXT01 branch October 16, 2022 21:31
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants