-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove potential runtime panic in x/feegrant #720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulbqb
changed the title
Remove potential runtime panic
Remove potential runtime panic in x/feegrant
Oct 17, 2022
ulbqb
changed the title
Remove potential runtime panic in x/feegrant
fix: remove potential runtime panic in x/feegrant
Oct 17, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #720 +/- ##
=======================================
Coverage 61.96% 61.96%
=======================================
Files 877 877
Lines 98764 98813 +49
=======================================
+ Hits 61200 61233 +33
- Misses 33955 33980 +25
+ Partials 3609 3600 -9
|
ulbqb
force-pushed
the
fix/unsafe_cast
branch
from
October 18, 2022 06:13
09c423c
to
ee66ae7
Compare
0Tech
reviewed
Oct 18, 2022
0Tech
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be better to provide more meaningful names to the mocks.
0Tech
reviewed
Oct 19, 2022
zemyblue
approved these changes
Oct 19, 2022
3 tasks
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I added safe type casting and then removed potential runtime panic.
Motivation and context
Unsafe type casting may cause potential runtime panic.
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.md
client/docs/swagger-ui/swagger.yaml